third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/NetworkResourcesData.h ('k') | third_party/WebKit/Source/core/layout/LayoutImageResource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp

diff --git a/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp b/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp

index 22e746d6794d73f0fed028aade40775a13b36e6f..cce304a97fa2582cd279ea197f8a3d956e980fae 100644

--- a/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp

+++ b/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp

@@ -29,6 +29,7 @@

#include "core/inspector/NetworkResourcesData.h"

#include "core/dom/DOMImplementation.h"

+#include "core/fetch/MemoryCache.h"

#include "core/fetch/Resource.h"

#include "platform/SharedBuffer.h"

#include "platform/network/ResourceResponse.h"

@@ -272,6 +273,7 @@ void NetworkResourcesData::maybeDecodeDataToContent(const String& requestId)

void NetworkResourcesData::addResource(const String& requestId, Resource* cachedResource)

{

+ ASSERT(memoryCache()->contains(cachedResource));

ResourceData* resourceData = resourceDataForRequestId(requestId);

if (!resourceData)

return;