third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h b/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h

index ff9ab12643f1cbe503541eabb826050f564e7066..f22b1463f791ec12277a844be4c5a61c8466fbf4 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h

@@ -6,7 +6,7 @@

#define InspectorResourceContentLoader_h

#include "core/CoreExport.h"

-#include "core/fetch/ResourcePtr.h"

+#include "core/fetch/Resource.h"

#include "wtf/Functional.h"

#include "wtf/HashSet.h"

#include "wtf/Noncopyable.h"

@@ -47,7 +47,7 @@ private:

bool m_started;

RawPtrWillBeMember<LocalFrame> m_inspectedFrame;

WillBeHeapHashSet<RawPtrWillBeMember<ResourceClient>> m_pendingResourceClients;

- Vector<ResourcePtr<Resource>> m_resources;

+ WillBeHeapVector<RefPtrWillBeMember<Resource>> m_resources;

friend class ResourceClient;

};