third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.h - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/TextResource.h ('k') | third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.h

diff --git a/third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.h b/third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.h

index f5a2332e85248ee9d7642bbb4ee77b5578d8a2e0..3368728357fff06c4faeb0a290834bae22ada1de 100644

--- a/third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.h

+++ b/third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.h

@@ -26,7 +26,6 @@

#ifndef XSLStyleSheetResource_h

#define XSLStyleSheetResource_h

-#include "core/fetch/ResourcePtr.h"

#include "core/fetch/StyleSheetResource.h"

namespace blink {

@@ -36,8 +35,8 @@ class ResourceFetcher;

class XSLStyleSheetResource final : public StyleSheetResource {

public:

- static ResourcePtr<XSLStyleSheetResource> fetchSynchronously(FetchRequest&, ResourceFetcher*);

- static ResourcePtr<XSLStyleSheetResource> fetch(FetchRequest&, ResourceFetcher*);

+ static PassRefPtrWillBeRawPtr<XSLStyleSheetResource> fetchSynchronously(FetchRequest&, ResourceFetcher*);

+ static PassRefPtrWillBeRawPtr<XSLStyleSheetResource> fetch(FetchRequest&, ResourceFetcher*);

const String& sheet() const { return m_sheet; }

@@ -49,9 +48,9 @@ protected:

XSLStyleSheetResourceFactory()

: ResourceFactory(Resource::XSLStyleSheet) { }

- Resource* create(const ResourceRequest& request, const String& charset) const override

+ PassRefPtrWillBeRawPtr<Resource> create(const ResourceRequest& request, const String& charset) const override

{

- return new XSLStyleSheetResource(request, charset);

+ return adoptRefWillBeNoop(new XSLStyleSheetResource(request, charset));

}

};

XSLStyleSheetResource(const ResourceRequest&, const String& charset);