third_party/WebKit/Source/core/fetch/ResourceLoader.h - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceLoader.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp ('k') | third_party/WebKit/Source/core/fetch/ResourceLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ResourceLoader.h

diff --git a/third_party/WebKit/Source/core/fetch/ResourceLoader.h b/third_party/WebKit/Source/core/fetch/ResourceLoader.h

index 734da2af12fed86c5880c5c8caf9825da99d1766..320c896a8e68f35be43f7d2469ba7dda0077ac80 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceLoader.h

+++ b/third_party/WebKit/Source/core/fetch/ResourceLoader.h

@@ -61,7 +61,7 @@ public:

void cancel(const ResourceError&);

void cancelIfNotFinishing();

- Resource* cachedResource() { return m_resource; }

+ Resource* cachedResource() { return m_resource.get(); }

const ResourceRequest& originalRequest() const { return m_originalRequest; }

void setDefersLoading(bool);

@@ -134,7 +134,7 @@ private:

ConnectionStateFailed,

};

- RawPtrWillBeMember<Resource> m_resource;

+ RefPtrWillBeMember<Resource> m_resource;

ResourceLoaderState m_state;

// Used for sanity checking to make sure we don't experience illegal state