Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: third_party/WebKit/Source/core/fetch/RawResource.cpp

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + address review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/RawResource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/RawResource.cpp b/third_party/WebKit/Source/core/fetch/RawResource.cpp
index 87e522b4e6c75c311755a047619441da57c52fc3..30a96b023081af94cc44414a6607ca8dfed7d31d 100644
--- a/third_party/WebKit/Source/core/fetch/RawResource.cpp
+++ b/third_party/WebKit/Source/core/fetch/RawResource.cpp
@@ -33,7 +33,7 @@
namespace blink {
-ResourcePtr<Resource> RawResource::fetchSynchronously(FetchRequest& request, ResourceFetcher* fetcher)
+PassRefPtrWillBeRawPtr<Resource> RawResource::fetchSynchronously(FetchRequest& request, ResourceFetcher* fetcher)
{
request.mutableResourceRequest().setTimeoutInterval(10);
ResourceLoaderOptions options(request.options());
@@ -42,21 +42,21 @@ ResourcePtr<Resource> RawResource::fetchSynchronously(FetchRequest& request, Res
return fetcher->requestResource(request, RawResourceFactory(Resource::Raw));
}
-ResourcePtr<RawResource> RawResource::fetchImport(FetchRequest& request, ResourceFetcher* fetcher)
+PassRefPtrWillBeRawPtr<RawResource> RawResource::fetchImport(FetchRequest& request, ResourceFetcher* fetcher)
{
ASSERT(request.resourceRequest().frameType() == WebURLRequest::FrameTypeNone);
request.mutableResourceRequest().setRequestContext(WebURLRequest::RequestContextImport);
return toRawResource(fetcher->requestResource(request, RawResourceFactory(Resource::ImportResource)));
}
-ResourcePtr<RawResource> RawResource::fetch(FetchRequest& request, ResourceFetcher* fetcher)
+PassRefPtrWillBeRawPtr<RawResource> RawResource::fetch(FetchRequest& request, ResourceFetcher* fetcher)
{
ASSERT(request.resourceRequest().frameType() == WebURLRequest::FrameTypeNone);
ASSERT(request.resourceRequest().requestContext() != WebURLRequest::RequestContextUnspecified);
return toRawResource(fetcher->requestResource(request, RawResourceFactory(Resource::Raw)));
}
-ResourcePtr<RawResource> RawResource::fetchMainResource(FetchRequest& request, ResourceFetcher* fetcher, const SubstituteData& substituteData)
+PassRefPtrWillBeRawPtr<RawResource> RawResource::fetchMainResource(FetchRequest& request, ResourceFetcher* fetcher, const SubstituteData& substituteData)
{
ASSERT(request.resourceRequest().frameType() != WebURLRequest::FrameTypeNone);
ASSERT(request.resourceRequest().requestContext() == WebURLRequest::RequestContextForm || request.resourceRequest().requestContext() == WebURLRequest::RequestContextFrame || request.resourceRequest().requestContext() == WebURLRequest::RequestContextHyperlink || request.resourceRequest().requestContext() == WebURLRequest::RequestContextIframe || request.resourceRequest().requestContext() == WebURLRequest::RequestContextInternal || request.resourceRequest().requestContext() == WebURLRequest::RequestContextLocation);
@@ -64,21 +64,21 @@ ResourcePtr<RawResource> RawResource::fetchMainResource(FetchRequest& request, R
return toRawResource(fetcher->requestResource(request, RawResourceFactory(Resource::MainResource), substituteData));
}
-ResourcePtr<RawResource> RawResource::fetchMedia(FetchRequest& request, ResourceFetcher* fetcher)
+PassRefPtrWillBeRawPtr<RawResource> RawResource::fetchMedia(FetchRequest& request, ResourceFetcher* fetcher)
{
ASSERT(request.resourceRequest().frameType() == WebURLRequest::FrameTypeNone);
ASSERT(request.resourceRequest().requestContext() == WebURLRequest::RequestContextAudio || request.resourceRequest().requestContext() == WebURLRequest::RequestContextVideo);
return toRawResource(fetcher->requestResource(request, RawResourceFactory(Resource::Media)));
}
-ResourcePtr<RawResource> RawResource::fetchTextTrack(FetchRequest& request, ResourceFetcher* fetcher)
+PassRefPtrWillBeRawPtr<RawResource> RawResource::fetchTextTrack(FetchRequest& request, ResourceFetcher* fetcher)
{
ASSERT(request.resourceRequest().frameType() == WebURLRequest::FrameTypeNone);
request.mutableResourceRequest().setRequestContext(WebURLRequest::RequestContextTrack);
return toRawResource(fetcher->requestResource(request, RawResourceFactory(Resource::TextTrack)));
}
-ResourcePtr<RawResource> RawResource::fetchManifest(FetchRequest& request, ResourceFetcher* fetcher)
+PassRefPtrWillBeRawPtr<RawResource> RawResource::fetchManifest(FetchRequest& request, ResourceFetcher* fetcher)
{
ASSERT(request.resourceRequest().frameType() == WebURLRequest::FrameTypeNone);
ASSERT(request.resourceRequest().requestContext() == WebURLRequest::RequestContextManifest);
@@ -94,7 +94,7 @@ void RawResource::appendData(const char* data, size_t length)
{
Resource::appendData(data, length);
- ResourcePtr<RawResource> protect(this);
+ RefPtrWillBeRawPtr<RawResource> protect(this);
ResourceClientWalker<RawResourceClient> w(m_clients);
while (RawResourceClient* c = w.next())
c->dataReceived(this, data, length);
@@ -107,7 +107,7 @@ void RawResource::didAddClient(ResourceClient* c)
// The calls to the client can result in events running, potentially causing
// this resource to be evicted from the cache and all clients to be removed,
// so a protector is necessary.
- ResourcePtr<RawResource> protect(this);
+ RefPtrWillBeRawPtr<RawResource> protect(this);
ASSERT(c->resourceClientType() == RawResourceClient::expectedType());
RawResourceClient* client = static_cast<RawResourceClient*>(c);
for (const auto& redirect : redirectChain()) {
@@ -130,7 +130,7 @@ void RawResource::didAddClient(ResourceClient* c)
void RawResource::willFollowRedirect(ResourceRequest& newRequest, const ResourceResponse& redirectResponse)
{
- ResourcePtr<RawResource> protect(this);
+ RefPtrWillBeRawPtr<RawResource> protect(this);
ASSERT(!redirectResponse.isNull());
ResourceClientWalker<RawResourceClient> w(m_clients);
while (RawResourceClient* c = w.next())
@@ -140,7 +140,7 @@ void RawResource::willFollowRedirect(ResourceRequest& newRequest, const Resource
void RawResource::updateRequest(const ResourceRequest& request)
{
- ResourcePtr<RawResource> protect(this);
+ RefPtrWillBeRawPtr<RawResource> protect(this);
ResourceClientWalker<RawResourceClient> w(m_clients);
while (RawResourceClient* c = w.next())
c->updateRequest(this, request);
@@ -148,7 +148,7 @@ void RawResource::updateRequest(const ResourceRequest& request)
void RawResource::responseReceived(const ResourceResponse& response, PassOwnPtr<WebDataConsumerHandle> handle)
{
- InternalResourcePtr protect(this);
+ RefPtrWillBeRawPtr<RawResource> protect(this);
bool isSuccessfulRevalidation = isCacheValidator() && response.httpStatusCode() == 304;
Resource::responseReceived(response, nullptr);
@@ -174,7 +174,7 @@ void RawResource::responseReceived(const ResourceResponse& response, PassOwnPtr<
void RawResource::setSerializedCachedMetadata(const char* data, size_t size)
{
- ResourcePtr<RawResource> protect(this);
+ RefPtrWillBeRawPtr<RawResource> protect(this);
Resource::setSerializedCachedMetadata(data, size);
ResourceClientWalker<RawResourceClient> w(m_clients);
while (RawResourceClient* c = w.next())
@@ -183,7 +183,7 @@ void RawResource::setSerializedCachedMetadata(const char* data, size_t size)
void RawResource::didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent)
{
- ResourcePtr<RawResource> protect(this);
+ RefPtrWillBeRawPtr<RawResource> protect(this);
ResourceClientWalker<RawResourceClient> w(m_clients);
while (RawResourceClient* c = w.next())
c->dataSent(this, bytesSent, totalBytesToBeSent);
@@ -191,7 +191,7 @@ void RawResource::didSendData(unsigned long long bytesSent, unsigned long long t
void RawResource::didDownloadData(int dataLength)
{
- ResourcePtr<RawResource> protect(this);
+ RefPtrWillBeRawPtr<RawResource> protect(this);
ResourceClientWalker<RawResourceClient> w(m_clients);
while (RawResourceClient* c = w.next())
c->dataDownloaded(this, dataLength);
« no previous file with comments | « third_party/WebKit/Source/core/fetch/RawResource.h ('k') | third_party/WebKit/Source/core/fetch/RawResourceTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698