third_party/WebKit/Source/core/fetch/LinkFetchResource.h - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/LinkFetchResource.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp ('k') | third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/LinkFetchResource.h

diff --git a/third_party/WebKit/Source/core/fetch/LinkFetchResource.h b/third_party/WebKit/Source/core/fetch/LinkFetchResource.h

index 654716d58f4284f198b51fc906f153282722e6fb..62d71315b3fb82dc30bc96c6b8f9948c63e921e5 100644

--- a/third_party/WebKit/Source/core/fetch/LinkFetchResource.h

+++ b/third_party/WebKit/Source/core/fetch/LinkFetchResource.h

@@ -8,7 +8,6 @@

#include "core/fetch/Resource.h"

#include "core/fetch/ResourceClient.h"

-#include "core/fetch/ResourcePtr.h"

namespace blink {

@@ -19,7 +18,7 @@ class LinkFetchResource final : public Resource {

public:

using ClientType = ResourceClient;

- static ResourcePtr<Resource> fetch(Resource::Type, FetchRequest&, ResourceFetcher*);

+ static PassRefPtrWillBeRawPtr<Resource> fetch(Resource::Type, FetchRequest&, ResourceFetcher*);

~LinkFetchResource() override;

private:

@@ -28,9 +27,9 @@ private:

LinkResourceFactory(Resource::Type type)

: ResourceFactory(type) { }

- Resource* create(const ResourceRequest& request, const String& charset) const override

+ PassRefPtrWillBeRawPtr<Resource> create(const ResourceRequest& request, const String& charset) const override

{

- return new LinkFetchResource(request, type());

+ return adoptRefWillBeNoop(new LinkFetchResource(request, type()));

}

};

LinkFetchResource(const ResourceRequest&, Type);