third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/ScriptRunner.h ('k') | third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

diff --git a/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h b/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

index b462afdac56605af45ff985a028f271bbb763f54..8f6d75e1d9edd40701a92f768d586dffd6dc4f4b 100644

--- a/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

+++ b/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h

@@ -27,7 +27,6 @@

#define CSSStyleSheetResource_h

#include "core/CoreExport.h"

-#include "core/fetch/ResourcePtr.h"

#include "core/fetch/StyleSheetResource.h"

#include "platform/heap/Handle.h"

@@ -43,8 +42,8 @@ class CORE_EXPORT CSSStyleSheetResource final : public StyleSheetResource {

public:

enum class MIMETypeCheck { Strict, Lax };

- static ResourcePtr<CSSStyleSheetResource> fetch(FetchRequest&, ResourceFetcher*);

- static ResourcePtr<CSSStyleSheetResource> createForTest(const ResourceRequest&, const String& charset);

+ static PassRefPtrWillBeRawPtr<CSSStyleSheetResource> fetch(FetchRequest&, ResourceFetcher*);

+ static PassRefPtrWillBeRawPtr<CSSStyleSheetResource> createForTest(const ResourceRequest&, const String& charset);

~CSSStyleSheetResource() override;

DECLARE_VIRTUAL_TRACE();

@@ -69,15 +68,15 @@ private:

CSSStyleSheetResourceFactory()

: ResourceFactory(Resource::CSSStyleSheet) { }

- Resource* create(const ResourceRequest& request, const String& charset) const override

+ PassRefPtrWillBeRawPtr<Resource> create(const ResourceRequest& request, const String& charset) const override

{

- return new CSSStyleSheetResource(request, charset);

+ return adoptRefWillBeNoop(new CSSStyleSheetResource(request, charset));

}

};

CSSStyleSheetResource(const ResourceRequest&, const String& charset);

bool canUseSheet(MIMETypeCheck) const;

- void dispose() override;

+ void removedFromMemoryCache() override;

void checkNotify() override;

String m_decodedSheetText;