third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp

diff --git a/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp b/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp

index fd53c61044953352e53fd52df916992e3147b486..c41eaf7d20185049564e65983285787c141346ab 100644

--- a/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp

+++ b/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp

@@ -165,7 +165,7 @@ void ProcessingInstruction::process(const String& href, const String& charset)

String url = document().completeURL(href).string();

- ResourcePtr<StyleSheetResource> resource;

+ RefPtrWillBeRawPtr<StyleSheetResource> resource = nullptr;

FetchRequest request(ResourceRequest(document().completeURL(href)), FetchInitiatorTypeNames::processinginstruction);

if (m_isXSL) {

if (RuntimeEnabledFeatures::xsltEnabled())

« no previous file with comments | « third_party/WebKit/Source/core/dom/PendingScript.cpp ('k') | third_party/WebKit/Source/core/dom/ScriptLoader.h » ('j') | no next file with comments »