third_party/WebKit/Source/core/css/CSSSVGDocumentValue.h - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSSVGDocumentValue.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSImageValue.cpp ('k') | third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSSVGDocumentValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSSVGDocumentValue.h b/third_party/WebKit/Source/core/css/CSSSVGDocumentValue.h

index edd23575a140a2c14bf2cd09307e86eb05b4ae4a..11dd452bc93cec110bf0094394e717dd926b9c2e 100644

--- a/third_party/WebKit/Source/core/css/CSSSVGDocumentValue.h

+++ b/third_party/WebKit/Source/core/css/CSSSVGDocumentValue.h

@@ -27,7 +27,6 @@

#include "core/css/CSSValue.h"

#include "core/fetch/DocumentResource.h"

-#include "core/fetch/ResourcePtr.h"

namespace blink {

@@ -49,13 +48,17 @@ public:

bool loadRequested() const { return m_loadRequested; }

bool equals(const CSSSVGDocumentValue&) const;

- DEFINE_INLINE_TRACE_AFTER_DISPATCH() { CSSValue::traceAfterDispatch(visitor); }

+ DEFINE_INLINE_TRACE_AFTER_DISPATCH()

+ {

+ visitor->trace(m_document);

+ CSSValue::traceAfterDispatch(visitor);

+ }

private:

CSSSVGDocumentValue(const String& url);

String m_url;

- ResourcePtr<DocumentResource> m_document;

+ RefPtrWillBeMember<DocumentResource> m_document;

bool m_loadRequested;

};