third_party/WebKit/Source/core/clipboard/DataTransfer.cpp - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

diff --git a/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp b/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

index 8e1e9c1d060a2501b4525d1745dae10ba63bc5a7..3b01ec0d7edb3030bfcb5de207654404409c16d5 100644

--- a/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

+++ b/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

@@ -230,7 +230,7 @@ void DataTransfer::clearDragImage()

if (!canSetDragImage())

return;

- m_dragImage = 0;

+ m_dragImage = nullptr;

m_dragLoc = IntPoint();

m_dragImageElement = nullptr;

}

@@ -513,6 +513,7 @@ String convertDragOperationToDropZoneOperation(DragOperation operation)

DEFINE_TRACE(DataTransfer)

{

visitor->trace(m_dataObject);

+ visitor->trace(m_dragImage);

#if ENABLE(OILPAN)

visitor->trace(m_dragImageElement);

#endif

« no previous file with comments | « third_party/WebKit/Source/core/clipboard/DataTransfer.h ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | no next file with comments »