third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp

index dfb64233937c17875c97fc53a8e5fa6b034d476b..bc41b08ebc0d9049527dc2c93bed913437e3d0ec 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp

@@ -7,8 +7,7 @@

namespace blink {

ScriptSourceCode::ScriptSourceCode()

- : m_resource(0)

- , m_startPosition(TextPosition::minimumPosition())

+ : m_startPosition(TextPosition::minimumPosition())

{

}

@@ -19,7 +18,6 @@ ScriptSourceCode::ScriptSourceCode(const String& source, const KURL& url, const

ScriptSourceCode::ScriptSourceCode(const CompressibleString& source, const KURL& url, const TextPosition& startPosition)

: m_source(source)

- , m_resource(0)

, m_url(url)

, m_startPosition(startPosition)

{

@@ -51,6 +49,7 @@ ScriptSourceCode::~ScriptSourceCode()

DEFINE_TRACE(ScriptSourceCode)

{

+ visitor->trace(m_resource);

visitor->trace(m_streamer);

}