third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix known issues Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/ScriptLoader.cpp ('K') | « third_party/WebKit/Source/core/svg/SVGFEImageElement.h ('k') | third_party/WebKit/Source/core/svg/SVGUseElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp b/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp

index 06768c75f12d4ce1d75365c0adc1e8171dd7b6b6..5cfd956306711e74deec99637f07e87c0ad5647e 100644

--- a/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp

@@ -47,7 +47,7 @@ SVGFEImageElement::~SVGFEImageElement()

#if ENABLE(OILPAN)

if (m_cachedImage) {

m_cachedImage->removeClient(this);

- m_cachedImage = 0;

+ m_cachedImage = nullptr;

}

#else

clearResourceReferences();

@@ -57,6 +57,7 @@ SVGFEImageElement::~SVGFEImageElement()

DEFINE_TRACE(SVGFEImageElement)

{

visitor->trace(m_preserveAspectRatio);

+ visitor->trace(m_cachedImage);

SVGFilterPrimitiveStandardAttributes::trace(visitor);

SVGURIReference::trace(visitor);

}

@@ -73,7 +74,7 @@ void SVGFEImageElement::clearResourceReferences()

{

if (m_cachedImage) {

m_cachedImage->removeClient(this);

- m_cachedImage = 0;

+ m_cachedImage = nullptr;

}

removeAllOutgoingReferences();