third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix known issues Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp ('K') | « third_party/WebKit/Source/core/css/RemoteFontFaceSource.h ('k') | third_party/WebKit/Source/core/css/StyleRuleImport.h » ('j') | third_party/WebKit/Source/core/dom/PendingScript.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

diff --git a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

index d86c598b9512fe720b0889b123ebb0c67f70b294..069122b9345bee4a5905d5ed5604238f768c03cc 100644

--- a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

+++ b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

@@ -17,7 +17,7 @@

namespace blink {

-RemoteFontFaceSource::RemoteFontFaceSource(FontResource* font, PassRefPtrWillBeRawPtr<FontLoader> fontLoader, FontDisplay display)

+RemoteFontFaceSource::RemoteFontFaceSource(PassRefPtrWillBeRawPtr<FontResource> font, PassRefPtrWillBeRawPtr<FontLoader> fontLoader, FontDisplay display)

: m_font(font)

, m_fontLoader(fontLoader)

, m_display(display)

@@ -49,6 +49,7 @@ RemoteFontFaceSource::~RemoteFontFaceSource()

void RemoteFontFaceSource::dispose()

{

m_font->removeClient(this);

+ m_font = nullptr;

pruneTable();

}

@@ -186,6 +187,7 @@ void RemoteFontFaceSource::beginLoadIfNeeded()

DEFINE_TRACE(RemoteFontFaceSource)

{

+ visitor->trace(m_font);

visitor->trace(m_fontLoader);

CSSFontFaceSource::trace(visitor);

}