third_party/WebKit/Source/core/css/FontLoader.h - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/FontLoader.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix known issues Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp ('K') | « third_party/WebKit/Source/core/css/FontFace.cpp ('k') | third_party/WebKit/Source/core/css/FontLoader.cpp » ('j') | third_party/WebKit/Source/core/dom/PendingScript.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/FontLoader.h

diff --git a/third_party/WebKit/Source/core/css/FontLoader.h b/third_party/WebKit/Source/core/css/FontLoader.h

index a7e76342e925f878f587eee4bfc2732404102bd8..9221b4f5553f1e36139f69a70b73247960fd4f40 100644

--- a/third_party/WebKit/Source/core/css/FontLoader.h

+++ b/third_party/WebKit/Source/core/css/FontLoader.h

@@ -6,7 +6,6 @@

#define FontLoader_h

#include "core/fetch/ResourceLoader.h"

-#include "core/fetch/ResourcePtr.h"

#include "platform/Timer.h"

#include "platform/heap/Handle.h"

#include "wtf/Vector.h"

@@ -44,7 +43,7 @@ private:

Timer<FontLoader> m_beginLoadingTimer;

struct FontToLoad;

- using FontsToLoadVector = Vector<OwnPtr<FontToLoad>>;

+ using FontsToLoadVector = WillBeHeapVector<OwnPtrWillBeMember<FontToLoad>>;

FontsToLoadVector m_fontsToBeginLoading;

RawPtrWillBeMember<CSSFontSelector> m_fontSelector;

RawPtrWillBeWeakMember<Document> m_document;