third_party/WebKit/Source/core/css/CSSImageSetValue.cpp - Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSImageSetValue.cpp

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix known issues Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp ('K') | « third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp ('k') | third_party/WebKit/Source/core/css/CSSImageValue.cpp » ('j') | third_party/WebKit/Source/core/dom/PendingScript.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSImageSetValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSImageSetValue.cpp b/third_party/WebKit/Source/core/css/CSSImageSetValue.cpp

index b68a44a5e156a534db3a60632aa1602f4b0581bb..aaf2bb08899d7aa0528e0a29f8c031d92a890a12 100644

--- a/third_party/WebKit/Source/core/css/CSSImageSetValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSImageSetValue.cpp

@@ -122,7 +122,7 @@ StyleImage* CSSImageSetValue::cacheImage(Document* document, float deviceScaleFa

if (crossOrigin != CrossOriginAttributeNotSet)

request.setCrossOriginAccessControl(document->securityOrigin(), crossOrigin);

- if (ResourcePtr<ImageResource> cachedImage = ImageResource::fetch(request, document->fetcher()))

+ if (RefPtrWillBeRawPtr<ImageResource> cachedImage = ImageResource::fetch(request, document->fetcher()))

m_cachedImage = StyleFetchedImageSet::create(cachedImage.get(), image.scaleFactor, this, request.url());

else

m_cachedImage = StyleInvalidImage::create(image.imageURL);