Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + address review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll <knoll@kde.org> 2 * Copyright (C) 1999 Lars Knoll <knoll@kde.org>
3 * Copyright (C) 1999 Antti Koivisto <koivisto@kde.org> 3 * Copyright (C) 1999 Antti Koivisto <koivisto@kde.org>
4 * Copyright (C) 2000 Dirk Mueller <mueller@kde.org> 4 * Copyright (C) 2000 Dirk Mueller <mueller@kde.org>
5 * Copyright (C) 2006 Allan Sandfeld Jensen <kde@carewolf.com> 5 * Copyright (C) 2006 Allan Sandfeld Jensen <kde@carewolf.com>
6 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 6 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. All rights reserved.
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Patrick Gansterer <paroga@paroga.com> 9 * Copyright (C) 2010 Patrick Gansterer <paroga@paroga.com>
10 * 10 *
(...skipping 23 matching lines...) Expand all
34 namespace blink { 34 namespace blink {
35 35
36 LayoutImageResourceStyleImage::LayoutImageResourceStyleImage(StyleImage* styleIm age) 36 LayoutImageResourceStyleImage::LayoutImageResourceStyleImage(StyleImage* styleIm age)
37 : m_styleImage(styleImage) 37 : m_styleImage(styleImage)
38 { 38 {
39 ASSERT(m_styleImage); 39 ASSERT(m_styleImage);
40 } 40 }
41 41
42 LayoutImageResourceStyleImage::~LayoutImageResourceStyleImage() 42 LayoutImageResourceStyleImage::~LayoutImageResourceStyleImage()
43 { 43 {
44 ASSERT(!m_cachedImage);
44 } 45 }
45 46
46 void LayoutImageResourceStyleImage::initialize(LayoutObject* layoutObject) 47 void LayoutImageResourceStyleImage::initialize(LayoutObject* layoutObject)
47 { 48 {
48 LayoutImageResource::initialize(layoutObject); 49 LayoutImageResource::initialize(layoutObject);
49 50
50 if (m_styleImage->isImageResource()) 51 if (m_styleImage->isImageResource())
51 m_cachedImage = toStyleFetchedImage(m_styleImage)->cachedImage(); 52 m_cachedImage = toStyleFetchedImage(m_styleImage)->cachedImage();
52 53
53 m_styleImage->addClient(m_layoutObject); 54 m_styleImage->addClient(m_layoutObject);
54 } 55 }
55 56
56 void LayoutImageResourceStyleImage::shutdown() 57 void LayoutImageResourceStyleImage::shutdown()
57 { 58 {
58 ASSERT(m_layoutObject); 59 ASSERT(m_layoutObject);
59 m_styleImage->removeClient(m_layoutObject); 60 m_styleImage->removeClient(m_layoutObject);
60 m_cachedImage = 0; 61 m_cachedImage = nullptr;
61 } 62 }
62 63
63 PassRefPtr<Image> LayoutImageResourceStyleImage::image(const IntSize& size, floa t zoom) const 64 PassRefPtr<Image> LayoutImageResourceStyleImage::image(const IntSize& size, floa t zoom) const
64 { 65 {
65 // Generated content may trigger calls to image() while we're still pending, don't assert but gracefully exit. 66 // Generated content may trigger calls to image() while we're still pending, don't assert but gracefully exit.
66 if (m_styleImage->isPendingImage()) 67 if (m_styleImage->isPendingImage())
67 return nullptr; 68 return nullptr;
68 return m_styleImage->image(m_layoutObject, size, zoom); 69 return m_styleImage->image(m_layoutObject, size, zoom);
69 } 70 }
70 71
71 DEFINE_TRACE(LayoutImageResourceStyleImage) 72 DEFINE_TRACE(LayoutImageResourceStyleImage)
72 { 73 {
73 visitor->trace(m_styleImage); 74 visitor->trace(m_styleImage);
74 LayoutImageResource::trace(visitor); 75 LayoutImageResource::trace(visitor);
75 } 76 }
76 77
77 } // namespace blink 78 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutImageResource.h ('k') | third_party/WebKit/Source/core/loader/DocumentLoader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698