Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutImageResource.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + address review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll <knoll@kde.org> 2 * Copyright (C) 1999 Lars Knoll <knoll@kde.org>
3 * Copyright (C) 1999 Antti Koivisto <koivisto@kde.org> 3 * Copyright (C) 1999 Antti Koivisto <koivisto@kde.org>
4 * Copyright (C) 2006 Allan Sandfeld Jensen <kde@carewolf.com> 4 * Copyright (C) 2006 Allan Sandfeld Jensen <kde@carewolf.com>
5 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 5 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2010 Patrick Gansterer <paroga@paroga.com> 7 * Copyright (C) 2010 Patrick Gansterer <paroga@paroga.com>
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
11 * License as published by the Free Software Foundation; either 11 * License as published by the Free Software Foundation; either
12 * version 2 of the License, or (at your option) any later version. 12 * version 2 of the License, or (at your option) any later version.
13 * 13 *
14 * This library is distributed in the hope that it will be useful, 14 * This library is distributed in the hope that it will be useful,
15 * but WITHOUT ANY WARRANTY; without even the implied warranty of 15 * but WITHOUT ANY WARRANTY; without even the implied warranty of
16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
17 * Library General Public License for more details. 17 * Library General Public License for more details.
18 * 18 *
19 * You should have received a copy of the GNU Library General Public License 19 * You should have received a copy of the GNU Library General Public License
20 * along with this library; see the file COPYING.LIB. If not, write to 20 * along with this library; see the file COPYING.LIB. If not, write to
21 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 21 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
22 * Boston, MA 02110-1301, USA. 22 * Boston, MA 02110-1301, USA.
23 * 23 *
24 */ 24 */
25 25
26 #ifndef LayoutImageResource_h 26 #ifndef LayoutImageResource_h
27 #define LayoutImageResource_h 27 #define LayoutImageResource_h
28 28
29 #include "core/fetch/ImageResource.h" 29 #include "core/fetch/ImageResource.h"
30 #include "core/fetch/ResourcePtr.h"
31 #include "core/style/StyleImage.h" 30 #include "core/style/StyleImage.h"
32 31
33 namespace blink { 32 namespace blink {
34 33
35 class LayoutObject; 34 class LayoutObject;
36 35
37 class LayoutImageResource : public NoBaseWillBeGarbageCollectedFinalized<LayoutI mageResource> { 36 class LayoutImageResource : public NoBaseWillBeGarbageCollectedFinalized<LayoutI mageResource> {
38 WTF_MAKE_NONCOPYABLE(LayoutImageResource); 37 WTF_MAKE_NONCOPYABLE(LayoutImageResource);
39 USING_FAST_MALLOC_WILL_BE_REMOVED(LayoutImageResource); 38 USING_FAST_MALLOC_WILL_BE_REMOVED(LayoutImageResource);
40 public: 39 public:
(...skipping 16 matching lines...) Expand all
57 56
58 virtual PassRefPtr<Image> image(const IntSize&, float) const; 57 virtual PassRefPtr<Image> image(const IntSize&, float) const;
59 virtual bool errorOccurred() const { return m_cachedImage && m_cachedImage-> errorOccurred(); } 58 virtual bool errorOccurred() const { return m_cachedImage && m_cachedImage-> errorOccurred(); }
60 59
61 virtual bool imageHasRelativeSize() const { return m_cachedImage ? m_cachedI mage->imageHasRelativeSize() : false; } 60 virtual bool imageHasRelativeSize() const { return m_cachedImage ? m_cachedI mage->imageHasRelativeSize() : false; }
62 61
63 virtual LayoutSize imageSize(float multiplier) const; 62 virtual LayoutSize imageSize(float multiplier) const;
64 63
65 virtual WrappedImagePtr imagePtr() const { return m_cachedImage.get(); } 64 virtual WrappedImagePtr imagePtr() const { return m_cachedImage.get(); }
66 65
67 DEFINE_INLINE_VIRTUAL_TRACE() { } 66 DEFINE_INLINE_VIRTUAL_TRACE() { visitor->trace(m_cachedImage); }
68 67
69 protected: 68 protected:
70 LayoutImageResource(); 69 LayoutImageResource();
71 LayoutObject* m_layoutObject; 70 LayoutObject* m_layoutObject;
72 ResourcePtr<ImageResource> m_cachedImage; 71 RefPtrWillBeMember<ImageResource> m_cachedImage;
73 }; 72 };
74 73
75 } // namespace blink 74 } // namespace blink
76 75
77 #endif // LayoutImage_h 76 #endif // LayoutImage_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698