Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: third_party/WebKit/Source/core/fetch/FontResource.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + address review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef FontResource_h 26 #ifndef FontResource_h
27 #define FontResource_h 27 #define FontResource_h
28 28
29 #include "core/fetch/Resource.h"
29 #include "core/fetch/ResourceClient.h" 30 #include "core/fetch/ResourceClient.h"
30 #include "core/fetch/ResourcePtr.h"
31 #include "platform/Timer.h" 31 #include "platform/Timer.h"
32 #include "platform/fonts/FontOrientation.h" 32 #include "platform/fonts/FontOrientation.h"
33 #include "wtf/OwnPtr.h" 33 #include "wtf/OwnPtr.h"
34 34
35 namespace blink { 35 namespace blink {
36 36
37 class FetchRequest; 37 class FetchRequest;
38 class ResourceFetcher; 38 class ResourceFetcher;
39 class FontPlatformData; 39 class FontPlatformData;
40 class FontCustomPlatformData; 40 class FontCustomPlatformData;
41 class FontResourceClient;
41 42
42 class FontResource final : public Resource { 43 class FontResource final : public Resource {
43 public: 44 public:
44 using ClientType = ResourceClient; 45 using ClientType = FontResourceClient;
45 46
46 static ResourcePtr<FontResource> fetch(FetchRequest&, ResourceFetcher*); 47 static PassRefPtrWillBeRawPtr<FontResource> fetch(FetchRequest&, ResourceFet cher*);
47 ~FontResource() override; 48 ~FontResource() override;
48 49
49 void load(ResourceFetcher*, const ResourceLoaderOptions&) override; 50 void load(ResourceFetcher*, const ResourceLoaderOptions&) override;
50 51
51 void didAddClient(ResourceClient*) override; 52 void didAddClient(ResourceClient*) override;
52 53
53 void allClientsRemoved() override; 54 void allClientsRemoved() override;
54 void beginLoadIfNeeded(ResourceFetcher* dl); 55 void beginLoadIfNeeded(ResourceFetcher* dl);
55 bool stillNeedsLoad() const override { return m_state < LoadInitiated; } 56 bool stillNeedsLoad() const override { return m_state < LoadInitiated; }
56 57
(...skipping 10 matching lines...) Expand all
67 68
68 protected: 69 protected:
69 bool isSafeToUnlock() const override; 70 bool isSafeToUnlock() const override;
70 71
71 private: 72 private:
72 class FontResourceFactory : public ResourceFactory { 73 class FontResourceFactory : public ResourceFactory {
73 public: 74 public:
74 FontResourceFactory() 75 FontResourceFactory()
75 : ResourceFactory(Resource::Font) { } 76 : ResourceFactory(Resource::Font) { }
76 77
77 Resource* create(const ResourceRequest& request, const String& charset) const override 78 PassRefPtrWillBeRawPtr<Resource> create(const ResourceRequest& request, const String& charset) const override
78 { 79 {
79 return new FontResource(request); 80 return adoptRefWillBeNoop(new FontResource(request));
80 } 81 }
81 }; 82 };
82 FontResource(const ResourceRequest&); 83 FontResource(const ResourceRequest&);
83 84
84 void checkNotify() override; 85 void checkNotify() override;
85 void fontLoadShortLimitCallback(Timer<FontResource>*); 86 void fontLoadShortLimitCallback(Timer<FontResource>*);
86 void fontLoadLongLimitCallback(Timer<FontResource>*); 87 void fontLoadLongLimitCallback(Timer<FontResource>*);
87 88
88 enum State { Unloaded, LoadScheduled, LoadInitiated, ShortLimitExceeded, Lon gLimitExceeded }; 89 enum State { Unloaded, LoadScheduled, LoadInitiated, ShortLimitExceeded, Lon gLimitExceeded };
89 90
(...skipping 16 matching lines...) Expand all
106 ResourceClientType resourceClientType() const final { return expectedType(); } 107 ResourceClientType resourceClientType() const final { return expectedType(); }
107 virtual void fontLoaded(FontResource*) {} 108 virtual void fontLoaded(FontResource*) {}
108 virtual void didStartFontLoad(FontResource*) {} 109 virtual void didStartFontLoad(FontResource*) {}
109 virtual void fontLoadShortLimitExceeded(FontResource*) {} 110 virtual void fontLoadShortLimitExceeded(FontResource*) {}
110 virtual void fontLoadLongLimitExceeded(FontResource*) {} 111 virtual void fontLoadLongLimitExceeded(FontResource*) {}
111 }; 112 };
112 113
113 } // namespace blink 114 } // namespace blink
114 115
115 #endif 116 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698