Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: third_party/WebKit/Source/core/fetch/DocumentResource.h

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + address review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 2010 Rob Buis <rwlbuis@gmail.com> 2 Copyright (C) 2010 Rob Buis <rwlbuis@gmail.com>
3 Copyright (C) 2011 Cosmin Truta <ctruta@gmail.com> 3 Copyright (C) 2011 Cosmin Truta <ctruta@gmail.com>
4 Copyright (C) 2012 University of Szeged 4 Copyright (C) 2012 University of Szeged
5 Copyright (C) 2012 Renata Hodovan <reni@webkit.org> 5 Copyright (C) 2012 Renata Hodovan <reni@webkit.org>
6 6
7 This library is free software; you can redistribute it and/or 7 This library is free software; you can redistribute it and/or
8 modify it under the terms of the GNU Library General Public 8 modify it under the terms of the GNU Library General Public
9 License as published by the Free Software Foundation; either 9 License as published by the Free Software Foundation; either
10 version 2 of the License, or (at your option) any later version. 10 version 2 of the License, or (at your option) any later version.
11 11
12 This library is distributed in the hope that it will be useful, 12 This library is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 13 but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15 Library General Public License for more details. 15 Library General Public License for more details.
16 16
17 You should have received a copy of the GNU Library General Public License 17 You should have received a copy of the GNU Library General Public License
18 along with this library; see the file COPYING.LIB. If not, write to 18 along with this library; see the file COPYING.LIB. If not, write to
19 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 19 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
20 Boston, MA 02110-1301, USA. 20 Boston, MA 02110-1301, USA.
21 */ 21 */
22 22
23 #ifndef DocumentResource_h 23 #ifndef DocumentResource_h
24 #define DocumentResource_h 24 #define DocumentResource_h
25 25
26 #include "core/fetch/Resource.h" 26 #include "core/fetch/Resource.h"
27 #include "core/fetch/ResourceClient.h" 27 #include "core/fetch/ResourceClient.h"
28 #include "core/fetch/ResourcePtr.h"
29 #include "core/html/parser/TextResourceDecoder.h" 28 #include "core/html/parser/TextResourceDecoder.h"
30 29
31 namespace blink { 30 namespace blink {
32 31
33 class Document; 32 class Document;
34 class FetchRequest; 33 class FetchRequest;
35 class ResourceFetcher; 34 class ResourceFetcher;
36 35
37 class DocumentResource final : public Resource { 36 class DocumentResource final : public Resource {
38 public: 37 public:
39 using ClientType = ResourceClient; 38 using ClientType = ResourceClient;
40 39
41 static ResourcePtr<DocumentResource> fetchSVGDocument(FetchRequest&, Resourc eFetcher*); 40 static PassRefPtrWillBeRawPtr<DocumentResource> fetchSVGDocument(FetchReques t&, ResourceFetcher*);
42 ~DocumentResource() override; 41 ~DocumentResource() override;
43 DECLARE_VIRTUAL_TRACE(); 42 DECLARE_VIRTUAL_TRACE();
44 43
45 Document* document() const { return m_document.get(); } 44 Document* document() const { return m_document.get(); }
46 45
47 void setEncoding(const String&) override; 46 void setEncoding(const String&) override;
48 String encoding() const override; 47 String encoding() const override;
49 void checkNotify() override; 48 void checkNotify() override;
50 49
51 private: 50 private:
52 class SVGDocumentResourceFactory : public ResourceFactory { 51 class SVGDocumentResourceFactory : public ResourceFactory {
53 public: 52 public:
54 SVGDocumentResourceFactory() 53 SVGDocumentResourceFactory()
55 : ResourceFactory(Resource::SVGDocument) { } 54 : ResourceFactory(Resource::SVGDocument) { }
56 55
57 Resource* create(const ResourceRequest& request, const String& charset) const override 56 PassRefPtrWillBeRawPtr<Resource> create(const ResourceRequest& request, const String& charset) const override
58 { 57 {
59 return new DocumentResource(request, Resource::SVGDocument); 58 return adoptRefWillBeNoop(new DocumentResource(request, Resource::SV GDocument));
60 } 59 }
61 }; 60 };
62 DocumentResource(const ResourceRequest&, Type); 61 DocumentResource(const ResourceRequest&, Type);
63 62
64 PassRefPtrWillBeRawPtr<Document> createDocument(const KURL&); 63 PassRefPtrWillBeRawPtr<Document> createDocument(const KURL&);
65 64
66 RefPtrWillBeMember<Document> m_document; 65 RefPtrWillBeMember<Document> m_document;
67 OwnPtr<TextResourceDecoder> m_decoder; 66 OwnPtr<TextResourceDecoder> m_decoder;
68 }; 67 };
69 68
70 DEFINE_TYPE_CASTS(DocumentResource, Resource, resource, resource->type() == Reso urce::SVGDocument, resource.type() == Resource::SVGDocument); \ 69 DEFINE_TYPE_CASTS(DocumentResource, Resource, resource, resource->type() == Reso urce::SVGDocument, resource.type() == Resource::SVGDocument); \
71 inline DocumentResource* toDocumentResource(const ResourcePtr<Resource>& ptr) { return toDocumentResource(ptr.get()); } 70 inline DocumentResource* toDocumentResource(const RefPtrWillBeRawPtr<Resource>& ptr) { return toDocumentResource(ptr.get()); }
72 71
73 class DocumentResourceClient : public ResourceClient { 72 class DocumentResourceClient : public ResourceClient {
74 public: 73 public:
75 ~DocumentResourceClient() override {} 74 ~DocumentResourceClient() override {}
76 static ResourceClientType expectedType() { return DocumentType; } 75 static ResourceClientType expectedType() { return DocumentType; }
77 ResourceClientType resourceClientType() const override { return expectedType (); } 76 ResourceClientType resourceClientType() const override { return expectedType (); }
78 }; 77 };
79 78
80 } // namespace blink 79 } // namespace blink
81 80
82 #endif // DocumentResource_h 81 #endif // DocumentResource_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698