Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + address review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org) 3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org) 4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 6 Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
7 7
8 This library is free software; you can redistribute it and/or 8 This library is free software; you can redistribute it and/or
9 modify it under the terms of the GNU Library General Public 9 modify it under the terms of the GNU Library General Public
10 License as published by the Free Software Foundation; either 10 License as published by the Free Software Foundation; either
(...skipping 19 matching lines...) Expand all
30 #include "core/fetch/FetchRequest.h" 30 #include "core/fetch/FetchRequest.h"
31 #include "core/fetch/ResourceClientWalker.h" 31 #include "core/fetch/ResourceClientWalker.h"
32 #include "core/fetch/ResourceFetcher.h" 32 #include "core/fetch/ResourceFetcher.h"
33 #include "core/fetch/StyleSheetResourceClient.h" 33 #include "core/fetch/StyleSheetResourceClient.h"
34 #include "platform/SharedBuffer.h" 34 #include "platform/SharedBuffer.h"
35 #include "platform/network/HTTPParsers.h" 35 #include "platform/network/HTTPParsers.h"
36 #include "wtf/CurrentTime.h" 36 #include "wtf/CurrentTime.h"
37 37
38 namespace blink { 38 namespace blink {
39 39
40 ResourcePtr<CSSStyleSheetResource> CSSStyleSheetResource::fetch(FetchRequest& re quest, ResourceFetcher* fetcher) 40 PassRefPtrWillBeRawPtr<CSSStyleSheetResource> CSSStyleSheetResource::fetch(Fetch Request& request, ResourceFetcher* fetcher)
41 { 41 {
42 ASSERT(request.resourceRequest().frameType() == WebURLRequest::FrameTypeNone ); 42 ASSERT(request.resourceRequest().frameType() == WebURLRequest::FrameTypeNone );
43 request.mutableResourceRequest().setRequestContext(WebURLRequest::RequestCon textStyle); 43 request.mutableResourceRequest().setRequestContext(WebURLRequest::RequestCon textStyle);
44 return toCSSStyleSheetResource(fetcher->requestResource(request, CSSStyleShe etResourceFactory())); 44 return toCSSStyleSheetResource(fetcher->requestResource(request, CSSStyleShe etResourceFactory()));
45 } 45 }
46 46
47 ResourcePtr<CSSStyleSheetResource> CSSStyleSheetResource::createForTest(const Re sourceRequest& request, const String& charset) 47 PassRefPtrWillBeRawPtr<CSSStyleSheetResource> CSSStyleSheetResource::createForTe st(const ResourceRequest& request, const String& charset)
48 { 48 {
49 return new CSSStyleSheetResource(request, charset); 49 return adoptRefWillBeNoop(new CSSStyleSheetResource(request, charset));
50 } 50 }
51 51
52 CSSStyleSheetResource::CSSStyleSheetResource(const ResourceRequest& resourceRequ est, const String& charset) 52 CSSStyleSheetResource::CSSStyleSheetResource(const ResourceRequest& resourceRequ est, const String& charset)
53 : StyleSheetResource(resourceRequest, CSSStyleSheet, "text/css", charset) 53 : StyleSheetResource(resourceRequest, CSSStyleSheet, "text/css", charset)
54 { 54 {
55 DEFINE_STATIC_LOCAL(const AtomicString, acceptCSS, ("text/css,*/*;q=0.1", At omicString::ConstructFromLiteral)); 55 DEFINE_STATIC_LOCAL(const AtomicString, acceptCSS, ("text/css,*/*;q=0.1", At omicString::ConstructFromLiteral));
56 56
57 // Prefer text/css but accept any type (dell.com serves a stylesheet 57 // Prefer text/css but accept any type (dell.com serves a stylesheet
58 // as text/html; see <http://bugs.webkit.org/show_bug.cgi?id=11451>). 58 // as text/html; see <http://bugs.webkit.org/show_bug.cgi?id=11451>).
59 setAccept(acceptCSS); 59 setAccept(acceptCSS);
60 } 60 }
61 61
62 CSSStyleSheetResource::~CSSStyleSheetResource() 62 CSSStyleSheetResource::~CSSStyleSheetResource()
63 { 63 {
64 // Make sure dispose() was cllaed before destruction. 64 // Make sure dispose() was cllaed before destruction.
65 ASSERT(!m_parsedStyleSheetCache); 65 ASSERT(!m_parsedStyleSheetCache);
66 } 66 }
67 67
68 void CSSStyleSheetResource::dispose() 68 void CSSStyleSheetResource::removedFromMemoryCache()
69 { 69 {
70 if (m_parsedStyleSheetCache) 70 if (m_parsedStyleSheetCache)
71 m_parsedStyleSheetCache->removedFromMemoryCache(); 71 m_parsedStyleSheetCache->removedFromMemoryCache();
72 m_parsedStyleSheetCache.clear(); 72 m_parsedStyleSheetCache.clear();
73 Resource::removedFromMemoryCache();
73 } 74 }
74 75
75 DEFINE_TRACE(CSSStyleSheetResource) 76 DEFINE_TRACE(CSSStyleSheetResource)
76 { 77 {
77 visitor->trace(m_parsedStyleSheetCache); 78 visitor->trace(m_parsedStyleSheetCache);
78 StyleSheetResource::trace(visitor); 79 StyleSheetResource::trace(visitor);
79 } 80 }
80 81
81 void CSSStyleSheetResource::didAddClient(ResourceClient* c) 82 void CSSStyleSheetResource::didAddClient(ResourceClient* c)
82 { 83 {
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 184
184 if (m_parsedStyleSheetCache) 185 if (m_parsedStyleSheetCache)
185 m_parsedStyleSheetCache->removedFromMemoryCache(); 186 m_parsedStyleSheetCache->removedFromMemoryCache();
186 m_parsedStyleSheetCache = sheet; 187 m_parsedStyleSheetCache = sheet;
187 m_parsedStyleSheetCache->addedToMemoryCache(); 188 m_parsedStyleSheetCache->addedToMemoryCache();
188 189
189 setDecodedSize(m_parsedStyleSheetCache->estimatedSizeInBytes()); 190 setDecodedSize(m_parsedStyleSheetCache->estimatedSizeInBytes());
190 } 191 }
191 192
192 } // namespace blink 193 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698