Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

Issue 1667843003: Make Resource RefCountedWillBeGarbageCollectedFinalized, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix known issues Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2010 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 380
381 ASSERT(pendingScript->resource()); 381 ASSERT(pendingScript->resource());
382 m_scriptsToExecuteAfterParsing.append(pendingScript.release()); 382 m_scriptsToExecuteAfterParsing.append(pendingScript.release());
383 } 383 }
384 384
385 bool HTMLScriptRunner::requestPendingScript(PendingScript* pendingScript, Elemen t* script) const 385 bool HTMLScriptRunner::requestPendingScript(PendingScript* pendingScript, Elemen t* script) const
386 { 386 {
387 ASSERT(!pendingScript->element()); 387 ASSERT(!pendingScript->element());
388 pendingScript->setElement(script); 388 pendingScript->setElement(script);
389 // This should correctly return 0 for empty or invalid srcValues. 389 // This should correctly return 0 for empty or invalid srcValues.
390 ScriptResource* resource = toScriptLoaderIfPossible(script)->resource().get( ); 390 ScriptResource* resource = toScriptLoaderIfPossible(script)->resource();
391 if (!resource) { 391 if (!resource) {
392 notImplemented(); // Dispatch error event. 392 notImplemented(); // Dispatch error event.
393 return false; 393 return false;
394 } 394 }
395 pendingScript->setScriptResource(resource); 395 pendingScript->setScriptResource(resource);
396 return true; 396 return true;
397 } 397 }
398 398
399 // Implements the initial steps for 'An end tag whose tag name is "script"' 399 // Implements the initial steps for 'An end tag whose tag name is "script"'
400 // http://whatwg.org/html#scriptEndTag 400 // http://whatwg.org/html#scriptEndTag
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 444
445 DEFINE_TRACE(HTMLScriptRunner) 445 DEFINE_TRACE(HTMLScriptRunner)
446 { 446 {
447 visitor->trace(m_document); 447 visitor->trace(m_document);
448 visitor->trace(m_host); 448 visitor->trace(m_host);
449 visitor->trace(m_parserBlockingScript); 449 visitor->trace(m_parserBlockingScript);
450 visitor->trace(m_scriptsToExecuteAfterParsing); 450 visitor->trace(m_scriptsToExecuteAfterParsing);
451 } 451 }
452 452
453 } // namespace blink 453 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698