Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1667723002: Use summary IDL file for interface classes. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use summary IDL file for interface classes. This CL makes a small change to the format of the summary IDL file: instead of containing classes with fields, it now contains classes with getters. This allows the classes in the IDL file to be directly used as interface classes, which makes code navigation much smoother. Since the IDL file is now being used directly by the code, it has been relocated to pkg/analyzer/lib/src/summary/idl.dart. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/30577548435ab3681736fb23724c8dd81d85dd8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+600 lines, -3535 lines) Patch
M pkg/analyzer/lib/src/generated/sdk_io.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 130 chunks +330 lines, -1770 lines 0 comments Download
A + pkg/analyzer/lib/src/summary/idl.dart View 32 chunks +190 lines, -174 lines 0 comments Download
M pkg/analyzer/lib/src/summary/name_filter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/prelink.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/prelinker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summarize_elements_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 15 chunks +66 lines, -68 lines 0 comments Download
D pkg/analyzer/tool/summary/idl.dart View 1 chunk +0 lines, -1515 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-03 13:26:29 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-03 16:16:36 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-03 16:57:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
30577548435ab3681736fb23724c8dd81d85dd8b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698