Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1667703002: Add missing dependency on metrics_profiler_ios on iOS. (Closed)

Created:
4 years, 10 months ago by sdefresne
Modified:
4 years, 10 months ago
Reviewers:
droger
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing dependency on metrics_profiler_ios on iOS. BUG=None Committed: https://crrev.com/3440900f5c73b88dc8ae66198a9cd28de2441f26 Cr-Commit-Position: refs/heads/master@{#373228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/chrome/ios_chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look.
4 years, 10 months ago (2016-02-03 12:15:37 UTC) #2
droger
lgtm
4 years, 10 months ago (2016-02-03 13:29:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667703002/1
4 years, 10 months ago (2016-02-03 13:43:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 13:50:53 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 13:52:55 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3440900f5c73b88dc8ae66198a9cd28de2441f26
Cr-Commit-Position: refs/heads/master@{#373228}

Powered by Google App Engine
This is Rietveld 408576698