Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1667663004: add note about security and new subclasses (Closed)

Created:
4 years, 10 months ago by reed1
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/ports/SkGlobalInitialization_default.cpp View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
reed1
4 years, 10 months ago (2016-02-03 23:49:24 UTC) #3
reed1
4 years, 10 months ago (2016-02-03 23:49:25 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667663004/1
4 years, 10 months ago (2016-02-03 23:49:42 UTC) #6
Oliver Chang
thanks for adding this! https://codereview.chromium.org/1667663004/diff/1/src/ports/SkGlobalInitialization_default.cpp File src/ports/SkGlobalInitialization_default.cpp (right): https://codereview.chromium.org/1667663004/diff/1/src/ports/SkGlobalInitialization_default.cpp#newcode51 src/ports/SkGlobalInitialization_default.cpp:51: // As new subclasses are ...
4 years, 10 months ago (2016-02-03 23:53:58 UTC) #8
reed1
https://codereview.chromium.org/1667663004/diff/1/src/ports/SkGlobalInitialization_default.cpp File src/ports/SkGlobalInitialization_default.cpp (right): https://codereview.chromium.org/1667663004/diff/1/src/ports/SkGlobalInitialization_default.cpp#newcode51 src/ports/SkGlobalInitialization_default.cpp:51: // As new subclasses are added here, they should ...
4 years, 10 months ago (2016-02-04 00:03:17 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667663004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667663004/40001
4 years, 10 months ago (2016-02-04 00:03:48 UTC) #11
Oliver Chang
lgtm, thanks again
4 years, 10 months ago (2016-02-04 00:03:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667663004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667663004/40001
4 years, 10 months ago (2016-02-04 00:05:19 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 00:31:38 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/50b98b424ccf780f76a1a6fb6e24940ffe681d53

Powered by Google App Engine
This is Rietveld 408576698