Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Unified Diff: third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp

Issue 1667653002: V8-binding: Use v8::Template::SetNativeDataProperty without setter for [Replaceable]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved the [LenientThis] test to http/tests/. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp b/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
index c11c0ac9ea7e628056c5db28225796c9efd224f1..33f94403be364547e2705f44c893a2e3e340d73c 100644
--- a/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
+++ b/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
@@ -51,7 +51,14 @@ public:
}
void clear() { m_loggedActivities.clear(); }
- bool verifyActivities(const Vector<String>& activities) const { return m_loggedActivities == activities; }
+ bool verifyActivities(const Vector<String>& expected) const
+ {
+ EXPECT_EQ(expected.size(), m_loggedActivities.size());
+ for (size_t i = 0; i < std::min(expected.size(), m_loggedActivities.size()); ++i) {
+ EXPECT_STREQ(expected[i].utf8().data(), m_loggedActivities[i].utf8().data());
+ }
+ return m_loggedActivities == expected;
+ }
private:
Vector<String> m_loggedActivities;
« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698