third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp - Issue 1667623002: Make sure Document::updateLayoutTree*() is called before Element::isFocusable().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp

Issue 1667623002: Make sure Document::updateLayoutTree*() is called before Element::isFocusable(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLLegendElement.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp b/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp

index 551d52026b058052756bb953ce8201a2a68f5c20..5789ab28bc65f15316f0a859e6b81771bb5f04ea 100644

--- a/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp

@@ -573,6 +573,7 @@ void DateTimeEditElement::focusByOwner(Element* oldFocusedElement)

if (oldFocusedElement && oldFocusedElement->isDateTimeFieldElement()) {

DateTimeFieldElement* oldFocusedField = static_cast<DateTimeFieldElement*>(oldFocusedElement);

size_t index = fieldIndexOf(*oldFocusedField);

+ document().updateLayoutTreeIgnorePendingStylesheets();

if (index != invalidFieldIndex && oldFocusedField->isFocusable()) {

oldFocusedField->focus();

return;

@@ -604,6 +605,7 @@ void DateTimeEditElement::fieldValueChanged()

bool DateTimeEditElement::focusOnNextFocusableField(size_t startIndex)

{

+ document().updateLayoutTreeIgnorePendingStylesheets();

for (size_t fieldIndex = startIndex; fieldIndex < m_fields.size(); ++fieldIndex) {

if (m_fields[fieldIndex]->isFocusable()) {

m_fields[fieldIndex]->focus();

@@ -626,6 +628,7 @@ bool DateTimeEditElement::focusOnPreviousField(const DateTimeFieldElement& field

const size_t startFieldIndex = fieldIndexOf(field);

if (startFieldIndex == invalidFieldIndex)

return false;

+ document().updateLayoutTreeIgnorePendingStylesheets();

size_t fieldIndex = startFieldIndex;

while (fieldIndex > 0) {

--fieldIndex;