Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1667553003: Make sure VS projects order is always the same in solution (Closed)

Created:
4 years, 10 months ago by Tomasz Moniuszko
Modified:
4 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure VS projects order is always the same in solution Solution file is being rewritten and reloaded by Visual Studio if projects order changes during 'gn gen' command. BUG=305761 Committed: https://crrev.com/17be731c097793e928e8d146c0dc7c8611e856b9 Cr-Commit-Position: refs/heads/master@{#373486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tools/gn/visual_studio_writer.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Tomasz Moniuszko
4 years, 10 months ago (2016-02-03 11:42:46 UTC) #1
Tomasz Moniuszko
4 years, 10 months ago (2016-02-03 11:43:01 UTC) #3
brettw
lgtm
4 years, 10 months ago (2016-02-03 18:32:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667553003/1
4 years, 10 months ago (2016-02-04 08:39:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 09:17:04 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 09:17:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17be731c097793e928e8d146c0dc7c8611e856b9
Cr-Commit-Position: refs/heads/master@{#373486}

Powered by Google App Engine
This is Rietveld 408576698