content/renderer/p2p/ipc_socket_factory.cc - Issue 166753002: Roll WebRTC 5523:5548.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/p2p/ipc_socket_factory.cc

Issue 166753002: Roll WebRTC 5523:5548. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: fixed the bots Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/p2p/ipc_socket_factory.cc

diff --git a/content/renderer/p2p/ipc_socket_factory.cc b/content/renderer/p2p/ipc_socket_factory.cc

index 80f26760aed71bc3ce405fd33d3b379156d3f0ba..9014003f5eb7d05482f31ee4eb1ab47fbf238021 100644

--- a/content/renderer/p2p/ipc_socket_factory.cc

+++ b/content/renderer/p2p/ipc_socket_factory.cc

@@ -50,7 +50,8 @@ bool JingleSocketOptionToP2PSocketOption(talk_base::Socket::Option option,

case talk_base::Socket::OPT_IPV6_V6ONLY:

return false; // Not supported by the chrome sockets.

default:

- NOTREACHED();

+ // TODO(mallinath):FIXME and add back NOTREACHED().

+// NOTREACHED();

Ronghua Wu (Left Chromium) 2014/02/14 16:37:00 looks like there's a new OPT_RTP_SENDTIME_EXTN_ID.

Mallinath (Gone from Chromium) 2014/02/14 17:12:24 Add OPT_RTP_SENDTIME_EXTN_ID below line 50. On 201

return false;

}

return true;