Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1667503004: Fix embarrassing bug in last-minute-change to yield* CL. (Closed)

Created:
4 years, 10 months ago by neis
Modified:
4 years, 10 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix embarrassing bug in last-minute change to yield* CL. R=littledan@chromium.org BUG= Committed: https://crrev.com/813f48ff7ead2db76a049824e7103ef00aab1d3a Cr-Commit-Position: refs/heads/master@{#33743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M src/parsing/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser.cc View 8 chunks +21 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
neis
4 years, 10 months ago (2016-02-04 15:56:57 UTC) #1
Dan Ehrenberg
lgtm
4 years, 10 months ago (2016-02-04 16:01:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667503004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667503004/1
4 years, 10 months ago (2016-02-04 16:06:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 16:36:16 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 16:36:51 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/813f48ff7ead2db76a049824e7103ef00aab1d3a
Cr-Commit-Position: refs/heads/master@{#33743}

Powered by Google App Engine
This is Rietveld 408576698