Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: tools/utils.py

Issue 166743002: Make building from bleeding edge tarball possible without Subversion installed (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/utils.py
diff --git a/tools/utils.py b/tools/utils.py
index 49ff0b112c5a0f1e7b70c997e99006507e74dba2..a8ad21d307fbff86d5acc8971f3ade9c49d612f2 100644
--- a/tools/utils.py
+++ b/tools/utils.py
@@ -318,6 +318,14 @@ def ReadVersionFile():
return None
def GetSVNRevision():
+ # When building from tarball use tools/SVN_REVISION
+ svn_revision_file = os.path.join(DART_DIR, 'tools', 'SVN_REVISION')
+ try:
+ with open(svn_revision_file) as fd:
+ return fd.read()
+ except:
+ pass
+
# FIXME(kustermann): Make this work for newer SVN versions as well (where
# we've got only one '.svn' directory)
custom_env = dict(os.environ)
@@ -339,14 +347,6 @@ def GetSVNRevision():
if revision:
return revision
- # When building from tarball use tools/SVN_REVISION
- svn_revision_file = os.path.join(DART_DIR, 'tools', 'SVN_REVISION')
- try:
- with open(svn_revision_file) as fd:
- return fd.read()
- except:
- pass
-
# Only fail on the buildbot in case of a SVN client version mismatch.
user = GetUserName()
if user != 'chrome-bot':
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698