Add support for uint8, uint16 and uint32 in luci/gae

Add support for uint8, uint16 and uint32 in luci/gae

This has come up for like 3 models in DM so far, and I'm tired of having this
be a stupid "gotcha!". I was working around it with some PropertyConverter, but
with this change it will just be obvious what the heck is going on.

They all map to positive int64 values (which should make indexes obvious), and
they include out-of-bounds checks on deserialization.

I excluded uint64, since there's no way to properly encode it in the native
datastore representation which still makes any sense for indexes.

I also added some (apparently?) missing documentation in PLS which explicitly
lays out what field types are allowed in a pls-managed struct.

R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org, vadimsh@chromium.org
BUG=550684
Committed: https://github.com/luci/gae/commit/daecce9bc5397d278cf86dbab752bc15ddb91b7c

[dnj, 2016-02-05 07:30:31]

lgtm w/ comment

https://chromiumcodereview.appspot.com/1667403003/diff/20001/service/datastor...
File service/datastore/pls_impl.go (right):

https://chromiumcodereview.appspot.com/1667403003/diff/20001/service/datastor...
service/datastore/pls_impl.go:412: if intVal < 0 || f.OverflowInt(intVal) {
We don't support negative integers here?

[iannucci, 2016-02-05 08:22:01]

https://chromiumcodereview.appspot.com/1667403003/diff/20001/service/datastor...
File service/datastore/pls_impl.go (right):

https://chromiumcodereview.appspot.com/1667403003/diff/20001/service/datastor...
service/datastore/pls_impl.go:412: if intVal < 0 || f.OverflowInt(intVal) {
On 2016/02/05 07:30:31, dnj wrote:
> We don't support negative integers here?

oops, copy pasta error. Fixed and added tests

[iannucci, 2016-02-05 08:22:19]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-02-05 08:22:19]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1667403003/#ps40001
(title: "allow negative")

[commit-bot: I haz the power, 2016-02-05 08:22:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667403003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667403003/40001

[commit-bot: I haz the power, 2016-02-05 08:26:40]

Description was changed from

==========
Add support for uint8, uint16 and uint32 in luci/gae

This has come up for like 3 models in DM so far, and I'm tired of having this
be a stupid "gotcha!". I was working around it with some PropertyConverter, but
with this change it will just be obvious what the heck is going on.

They all map to positive int64 values (which should make indexes obvious), and
they include out-of-bounds checks on deserialization.

I excluded uint64, since there's no way to properly encode it in the native
datastore representation which still makes any sense for indexes.

I also added some (apparently?) missing documentation in PLS which explicitly
lays out what field types are allowed in a pls-managed struct.

R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org,
vadimsh@chromium.org
BUG=550684
==========

to

==========
Add support for uint8, uint16 and uint32 in luci/gae

This has come up for like 3 models in DM so far, and I'm tired of having this
be a stupid "gotcha!". I was working around it with some PropertyConverter, but
with this change it will just be obvious what the heck is going on.

They all map to positive int64 values (which should make indexes obvious), and
they include out-of-bounds checks on deserialization.

I excluded uint64, since there's no way to properly encode it in the native
datastore representation which still makes any sense for indexes.

I also added some (apparently?) missing documentation in PLS which explicitly
lays out what field types are allowed in a pls-managed struct.

R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org,
vadimsh@chromium.org
BUG=550684

Committed:
https://github.com/luci/gae/commit/daecce9bc5397d278cf86dbab752bc15ddb91b7c
==========

[commit-bot: I haz the power, 2016-02-05 08:26:41]

Committed patchset #3 (id:40001) as
https://github.com/luci/gae/commit/daecce9bc5397d278cf86dbab752bc15ddb91b7c