[Findit] Adding master_name, builder_name, and try_job_type to try_job_data

[Findit] Adding master_name and builder_name to try_job_data

This change also makes master_name, builder_name, request_time, start_time, and end_time indexed by default to enable querying.

BUG=584477
Committed: https://chromium.googlesource.com/infra/infra/+/2f870cc65d8f66ef9807f790d879bc7b500f7500

[lijeffrey, 2016-02-05 00:46:25]

Description was changed from

==========
[Findit] Adding master_name and builder_name to try_job_data

[Findit] Adding master_name and builder_name to try_job_data

BUG=
==========

to

==========
[Findit] Adding master_name and builder_name to try_job_data

This change also makes master_name, builder_name, request_time, start_time, and
end_time indexed by default to enable querying.

BUG=584477
==========

[lijeffrey, 2016-02-05 00:46:25]

lijeffrey@chromium.org changed reviewers:
+ chanli@chromium.org, stgao@chromium.org

[lijeffrey, 2016-02-05 00:47:47]

ptal

[chanli, 2016-02-05 00:55:38]

On 2016/02/05 00:47:47, lijeffrey wrote:
> ptal

lgtm.

[stgao, 2016-02-05 00:59:14]

https://codereview.chromium.org/1667383002/diff/20001/appengine/findit/model/...
File appengine/findit/model/wf_try_job_data.py (right):

https://codereview.chromium.org/1667383002/diff/20001/appengine/findit/model/...
appengine/findit/model/wf_try_job_data.py:8: class WfTryJobData(ndb.Model):
A side note: later, we need to monitor the number of Swarming task Findit
triggers too.

It could be in a different model though.

https://codereview.chromium.org/1667383002/diff/20001/appengine/findit/model/...
appengine/findit/model/wf_try_job_data.py:8: class WfTryJobData(ndb.Model):
Just found that we didn't save the try job type, which is important in measuring
the try jobs.

If there is no easy way to get the try job type, we might want to save it here.

Or we could save the key of the corresponding WfTryJob in WfTryJobData here and
get more data later from the WfTryJob.

[lijeffrey, 2016-02-05 01:11:20]

https://codereview.chromium.org/1667383002/diff/20001/appengine/findit/model/...
File appengine/findit/model/wf_try_job_data.py (right):

https://codereview.chromium.org/1667383002/diff/20001/appengine/findit/model/...
appengine/findit/model/wf_try_job_data.py:8: class WfTryJobData(ndb.Model):
On 2016/02/05 00:59:13, stgao wrote:
> Just found that we didn't save the try job type, which is important in
measuring
> the try jobs.
> 
> If there is no easy way to get the try job type, we might want to save it
here.
> 
> Or we could save the key of the corresponding WfTryJob in WfTryJobData here
and
> get more data later from the WfTryJob.

Done.

[stgao, 2016-02-05 01:35:35]

lgtm

[lijeffrey, 2016-02-05 01:37:29]

The CQ bit was checked by lijeffrey@chromium.org

[lijeffrey, 2016-02-05 01:37:30]

The patchset sent to the CQ was uploaded after l-g-t-m from chanli@chromium.org
Link to the patchset: https://codereview.chromium.org/1667383002/#ps40001
(title: "Addressing comments and rebase")

[commit-bot: I haz the power, 2016-02-05 01:37:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667383002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667383002/40001

[commit-bot: I haz the power, 2016-02-05 01:42:23]

Description was changed from

==========
[Findit] Adding master_name and builder_name to try_job_data

This change also makes master_name, builder_name, request_time, start_time, and
end_time indexed by default to enable querying.

BUG=584477
==========

to

==========
[Findit] Adding master_name and builder_name to try_job_data

This change also makes master_name, builder_name, request_time, start_time, and
end_time indexed by default to enable querying.

BUG=584477

Committed:
https://chromium.googlesource.com/infra/infra/+/2f870cc65d8f66ef9807f790d879b...
==========

[commit-bot: I haz the power, 2016-02-05 01:42:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/2f870cc65d8f66ef9807f790d879b...