Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1667353003: Error reporting for number-or-percentage (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
CC:
blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Error reporting for number-or-percentage Move parseNumberOrPercentage from SVGParserUtilities to SVGNumber (since it's the only user) and simplify it. BUG=231612 Committed: https://crrev.com/b94e5ddff68c84d87bdfeb2a3f828c1bedb38318 Cr-Commit-Position: refs/heads/master@{#373899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -42 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumber.cpp View 1 chunk +33 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParserUtilities.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParserUtilities.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParsingError.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParsingError.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
fs
4 years, 10 months ago (2016-02-05 18:52:15 UTC) #2
Stephen Chennney
How does the test result change? I'm assuming messages are better, but I would like ...
4 years, 10 months ago (2016-02-05 19:00:31 UTC) #3
fs
On 2016/02/05 at 19:00:31, schenney wrote: > How does the test result change? I'm assuming ...
4 years, 10 months ago (2016-02-05 19:13:56 UTC) #4
Stephen Chennney
On 2016/02/05 19:13:56, fs wrote: > On 2016/02/05 at 19:00:31, schenney wrote: > > How ...
4 years, 10 months ago (2016-02-05 19:43:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667353003/1
4 years, 10 months ago (2016-02-05 19:57:58 UTC) #7
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
4 years, 10 months ago (2016-02-05 20:11:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667353003/1
4 years, 10 months ago (2016-02-05 20:22:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 20:38:00 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 20:39:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b94e5ddff68c84d87bdfeb2a3f828c1bedb38318
Cr-Commit-Position: refs/heads/master@{#373899}

Powered by Google App Engine
This is Rietveld 408576698