Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1667333002: Update README.md to match new master branch (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : typo #

Patch Set 3 : Remove note about 'merge to xfa' #

Patch Set 4 : small wordsmithing #

Total comments: 10

Patch Set 5 : Lei's comments #

Patch Set 6 : One more. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M README.md View 1 2 3 4 5 3 chunks +22 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, quick review.
4 years, 10 months ago (2016-02-04 23:10:13 UTC) #1
Lei Zhang
lgtm, some suggestions and a typo correction: https://codereview.chromium.org/1667333002/diff/60001/README.md File README.md (right): https://codereview.chromium.org/1667333002/diff/60001/README.md#newcode52 README.md:52: or without ...
4 years, 10 months ago (2016-02-04 23:32:10 UTC) #2
Tom Sepez
Committed patchset #6 (id:100001) manually as d43654af40fd78621f683d445654d11919ac6c52 (tree was closed).
4 years, 10 months ago (2016-02-04 23:36:17 UTC) #4
Tom Sepez
4 years, 10 months ago (2016-02-04 23:41:44 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1667333002/diff/60001/README.md
File README.md (right):

https://codereview.chromium.org/1667333002/diff/60001/README.md#newcode52
README.md:52: or without XFA forms support.  By default, both of these are
present in
On 2016/02/04 23:32:10, Lei Zhang wrote:
> "Both of these features are enabled by default." ?

Done.

https://codereview.chromium.org/1667333002/diff/60001/README.md#newcode53
README.md:53: your build. Also note that if you wish to exclude JavaScript, then
XFA
On 2016/02/04 23:32:10, Lei Zhang wrote:
> Also note that the XFA feature requires JavaScript.

Done.

https://codereview.chromium.org/1667333002/diff/60001/README.md#newcode57
README.md:57: To build without JavaScript set `pdf_enable_v8=0 pdf_enable_xfa=0`
before
On 2016/02/04 23:32:10, Lei Zhang wrote:
> add a comma after "without JavaScript"

Done.

https://codereview.chromium.org/1667333002/diff/60001/README.md#newcode62
README.md:62: gives the smalles possible build configuration.
On 2016/02/04 23:32:10, Lei Zhang wrote:
> smallest

argh

https://codereview.chromium.org/1667333002/diff/60001/README.md#newcode143
README.md:143: The origin/xfa branch is now an evolutionary dead-end. Everything
you need
On 2016/02/04 23:32:10, Lei Zhang wrote:
> Prepend: Prior to 2016-02-04, there existed an actively developed origin/xfa
> branch.

Done.

Powered by Google App Engine
This is Rietveld 408576698