Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1667303002: - Move flags from heap.cc into the flag list. (Closed)

Created:
4 years, 10 months ago by Ivan Posva
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Move flags from heap.cc into the flag list. - Remove random debug prints. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/2493c5dcd62d57bb4484020ffed14e0069ced77b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -32 lines) Patch
M runtime/vm/flag_list.h View 1 chunk +31 lines, -8 lines 0 comments Download
M runtime/vm/heap.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/heap.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M runtime/vm/scavenger.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/weak_code.cc View 1 chunk +0 lines, -2 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Ivan Posva
4 years, 10 months ago (2016-02-04 22:43:51 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1667303002/diff/1/runtime/vm/weak_code.cc File runtime/vm/weak_code.cc (left): https://codereview.chromium.org/1667303002/diff/1/runtime/vm/weak_code.cc#oldcode105 runtime/vm/weak_code.cc:105: OS::Print("Skipping code owned by class %s\n", cls.ToCString()); Yikes
4 years, 10 months ago (2016-02-05 00:44:07 UTC) #3
Ivan Posva
4 years, 10 months ago (2016-02-05 00:49:43 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2493c5dcd62d57bb4484020ffed14e0069ced77b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698