For provided file systems; a) directory tree only navigates open nodes. b) Tree closes child nodes …

Improve performance of the directory tree in the files app for large network shares.

For provided file systems;
a) Directory tree only navigates open nodes.
b) Tree closes child nodes when parent closes.
c) Expander arrows are always added rather than traversing the children to determine if needed.
d) Expander arrows will disappear if expanded and there is no content.

BUG=584404
Committed: https://crrev.com/81355b7f55b4bf8a645731eb2f94df84cca2eaf2
Cr-Commit-Position: refs/heads/master@{#374779}

[zentaro, 2016-02-05 02:17:32]

Description was changed from

==========
For provided file systems; a) directory tree only navigates open nodes. b) Tree
closes child nodes when parent closes. c) Expander arrows are always added
rather than traversing the children to determine if needed. d) Expander arrows
will disappear if expanded and there is no content.

BUG=
==========

to

==========
For provided file systems; a) directory tree only navigates open nodes. b) Tree
closes child nodes when parent closes. c) Expander arrows are always added
rather than traversing the children to determine if needed. d) Expander arrows
will disappear if expanded and there is no content.

BUG=
==========

[zentaro, 2016-02-05 02:17:32]

zentaro@chromium.org changed reviewers:
+ mtomasz@chromium.org

[mtomasz, 2016-02-05 02:22:58]

Basically lgtm. Please fix the CL description format:

Subject\n\nDescription\n\nBUG=...

https://codereview.chromium.org/1667163003/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right):

https://codereview.chromium.org/1667163003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:529:
item.delayExpansion = (item.volumeInfo.volumeType == "provided");
nit: === in Files app code

[zentaro, 2016-02-09 03:18:03]

Description was changed from

==========
For provided file systems; a) directory tree only navigates open nodes. b) Tree
closes child nodes when parent closes. c) Expander arrows are always added
rather than traversing the children to determine if needed. d) Expander arrows
will disappear if expanded and there is no content.

BUG=
==========

to

==========
Improve performance of the directory tree in the files app for large network
shares.


For provided file systems; 
a) Directory tree only navigates open nodes. 
b) Tree closes child nodes when parent closes. 
c) Expander arrows are always added rather than traversing the children to
determine if needed. 
d) Expander arrows will disappear if expanded and there is no content.


BUG=584404
==========

[zentaro, 2016-02-09 03:18:28]

On 2016/02/05 02:22:58, mtomasz wrote:
> Basically lgtm. Please fix the CL description format:
> 
> Subject\n\nDescription\n\nBUG=...
> 
>
https://codereview.chromium.org/1667163003/diff/1/ui/file_manager/file_manage...
> File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right):
> 
>
https://codereview.chromium.org/1667163003/diff/1/ui/file_manager/file_manage...
> ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:529:
> item.delayExpansion = (item.volumeInfo.volumeType == "provided");
> nit: === in Files app code

Done.

[zentaro, 2016-02-09 03:18:36]

https://codereview.chromium.org/1667163003/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right):

https://codereview.chromium.org/1667163003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:529:
item.delayExpansion = (item.volumeInfo.volumeType == "provided");
On 2016/02/05 02:22:57, mtomasz wrote:
> nit: === in Files app code

Done. (And " -> ')

[zentaro, 2016-02-09 05:10:26]

The CQ bit was checked by zentaro@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 05:11:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667163003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667163003/20001

[commit-bot: I haz the power, 2016-02-09 05:35:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 05:35:52]

Dry run: This issue passed the CQ dry run.

[zentaro, 2016-02-10 22:49:23]

The CQ bit was checked by zentaro@chromium.org

[zentaro, 2016-02-10 22:49:23]

The patchset sent to the CQ was uploaded after l-g-t-m from mtomasz@chromium.org
Link to the patchset: https://codereview.chromium.org/1667163003/#ps20001
(title: "Fix review issues.")

[commit-bot: I haz the power, 2016-02-10 22:51:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667163003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667163003/20001

[commit-bot: I haz the power, 2016-02-10 23:31:48]

Description was changed from

==========
Improve performance of the directory tree in the files app for large network
shares.


For provided file systems; 
a) Directory tree only navigates open nodes. 
b) Tree closes child nodes when parent closes. 
c) Expander arrows are always added rather than traversing the children to
determine if needed. 
d) Expander arrows will disappear if expanded and there is no content.


BUG=584404
==========

to

==========
Improve performance of the directory tree in the files app for large network
shares.


For provided file systems; 
a) Directory tree only navigates open nodes. 
b) Tree closes child nodes when parent closes. 
c) Expander arrows are always added rather than traversing the children to
determine if needed. 
d) Expander arrows will disappear if expanded and there is no content.


BUG=584404
==========

[commit-bot: I haz the power, 2016-02-10 23:31:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:32:32]

Description was changed from

==========
Improve performance of the directory tree in the files app for large network
shares.


For provided file systems; 
a) Directory tree only navigates open nodes. 
b) Tree closes child nodes when parent closes. 
c) Expander arrows are always added rather than traversing the children to
determine if needed. 
d) Expander arrows will disappear if expanded and there is no content.


BUG=584404
==========

to

==========
Improve performance of the directory tree in the files app for large network
shares.

For provided file systems;
a) Directory tree only navigates open nodes.
b) Tree closes child nodes when parent closes.
c) Expander arrows are always added rather than traversing the children to
determine if needed.
d) Expander arrows will disappear if expanded and there is no content.

BUG=584404

Committed: https://crrev.com/81355b7f55b4bf8a645731eb2f94df84cca2eaf2
Cr-Commit-Position: refs/heads/master@{#374779}
==========

[commit-bot: I haz the power, 2016-02-16 22:32:33]

Patchset 2 (id:??) landed as
https://crrev.com/81355b7f55b4bf8a645731eb2f94df84cca2eaf2
Cr-Commit-Position: refs/heads/master@{#374779}