content/test/data/frame_tree/page_with_srcdoc_frame.html - Issue 1667163002: Add methods to NavigationHandle to allow refactoring webNavigation to use it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/data/frame_tree/page_with_srcdoc_frame.html

Issue 1667163002: Add methods to NavigationHandle to allow refactoring webNavigation to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on Camille's review. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/browser/navigation_handle.cc ('k') | testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/data/frame_tree/page_with_srcdoc_frame.html

diff --git a/third_party/WebKit/Source/web/tests/data/visible_frames.html b/content/test/data/frame_tree/page_with_srcdoc_frame.html

similarity index 55%

copy from third_party/WebKit/Source/web/tests/data/visible_frames.html

copy to content/test/data/frame_tree/page_with_srcdoc_frame.html

index 6d0820f869edc34573bf2773087feb33efc1411b..7745de470570e3087ee032c639b65af652dbfcab 100644

--- a/third_party/WebKit/Source/web/tests/data/visible_frames.html

+++ b/content/test/data/frame_tree/page_with_srcdoc_frame.html

@@ -1,2 +1 @@

-<iframe srcdoc=""><iframe>