Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 1667163002: Add methods to NavigationHandle to allow refactoring webNavigation to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on Camille's review. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_handle_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index 6248b18accd8b00aeed381575909ca6fac07f16f..af22321e4da36b8b9cc45bb906bc88fec66d1ba1 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -70,12 +70,20 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
static scoped_ptr<NavigationHandleImpl> Create(
const GURL& url,
FrameTreeNode* frame_tree_node,
+ bool is_synchronous,
+ bool is_srcdoc,
const base::TimeTicks& navigation_start);
~NavigationHandleImpl() override;
// NavigationHandle implementation:
const GURL& GetURL() override;
bool IsInMainFrame() override;
+ bool IsParentMainFrame() override;
+ bool IsSynchronousNavigation() override;
+ bool IsSrcdoc() override;
+ bool WasServerRedirect() override;
+ int GetFrameTreeNodeId() override;
+ int GetParentFrameTreeNodeId() override;
const base::TimeTicks& NavigationStart() override;
bool IsPost() override;
const Referrer& GetReferrer() override;
@@ -201,6 +209,8 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
NavigationHandleImpl(const GURL& url,
FrameTreeNode* frame_tree_node,
+ bool is_synchronous,
+ bool is_srcdoc,
const base::TimeTicks& navigation_start);
NavigationThrottle::ThrottleCheckResult CheckWillStartRequest();
@@ -223,6 +233,9 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
net::Error net_error_code_;
RenderFrameHostImpl* render_frame_host_;
bool is_same_page_;
+ const bool is_synchronous_;
+ const bool is_srcdoc_;
+ bool was_redirected_;
scoped_refptr<net::HttpResponseHeaders> response_headers_;
// The state the navigation is in.
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_handle_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698