Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1667133002: Revert of Update V8 to version 4.10.155. (Closed)

Created:
4 years, 10 months ago by sgurun-gerrit only
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 4.10.155. (patchset #1 id:1 of https://codereview.chromium.org/1669813002/ ) Reason for revert: build break, see https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Builder/builds/61241 Original issue's description: > Update V8 to version 4.10.155. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/d425d920..45528bd7 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org > > Committed: https://crrev.com/0df18d057870a0524c1f50dc10256975929a7f58 > Cr-Commit-Position: refs/heads/master@{#373552} TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
sgurun-gerrit only
Created Revert of Update V8 to version 4.10.155.
4 years, 10 months ago (2016-02-04 17:33:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667133002/1
4 years, 10 months ago (2016-02-04 17:34:24 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 17:35:54 UTC) #4
Failed to apply patch for DEPS:
While running git apply --index -3 -p1;
  error: patch failed: DEPS:43
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: DEPS: patch does not apply

Patch:       DEPS
Index: DEPS
diff --git a/DEPS b/DEPS
index
5932f95c20a3e19d06a186ef2bfb6eb868f7a944..1f9eb14bdeb217841ed7c0680f3389ddd63841ea
100644
--- a/DEPS
+++ b/DEPS
@@ -43,7 +43,7 @@
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling V8
   # and whatever else without interference from each other.
-  'v8_revision': '45528bd7a1114ef49553d0d30773ffcc85c061e6',
+  'v8_revision': 'd425d92035269ffe19575d0dea936b1cfe1fb480',
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling swarming_client
   # and whatever else without interference from each other.

Powered by Google App Engine
This is Rietveld 408576698