Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1667113002: Don't print dialog box prior to crashing. (Closed)

Created:
4 years, 10 months ago by djsollen
Modified:
4 years, 10 months ago
Reviewers:
dogben, caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't print dialog box prior to crashing. This returns us to our previous behavior when we used 0xbbadbeef to cause the process to terminate. BUG=skia:4893 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1667113002 Committed: https://skia.googlesource.com/skia/+/6b48984333029f2ad94a06339b2329bda8ee09ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/ports/SkMemory_malloc.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
djsollen
4 years, 10 months ago (2016-02-04 16:25:14 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667113002/1
4 years, 10 months ago (2016-02-04 16:25:22 UTC) #5
caryclark
lgtm
4 years, 10 months ago (2016-02-04 16:26:21 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 16:53:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667113002/1
4 years, 10 months ago (2016-02-04 16:58:52 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 16:59:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6b48984333029f2ad94a06339b2329bda8ee09ba

Powered by Google App Engine
This is Rietveld 408576698