[interpreter, debugger] implement debugger statement.

[interpreter, debugger] implement debugger statement.

R=mstarzinger@chromium.org, rmcilroy@chromium.org
BUG=v8:4690
LOG=N

Committed: https://crrev.com/86164a2573a7c1bbf2d29f8d03de35fa7fff5c81
Cr-Commit-Position: refs/heads/master@{#33739}

[Yang, 2016-02-04 10:43:20]

Description was changed from

==========
[interpreter, debugger] implement debugger statement.

R=mstarzinger@chromium.org, rmcilroy@chromium.org
BUG=v8:4960
LOG=N
==========

to

==========
[interpreter, debugger] implement debugger statement.

R=mstarzinger@chromium.org, rmcilroy@chromium.org
BUG=v8:4690
LOG=N
==========

[Michael Starzinger, 2016-02-04 11:45:38]

LGTM from my end.

https://codereview.chromium.org/1667073002/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):

https://codereview.chromium.org/1667073002/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:1807: // Debugger statement
nit: Drop "statement".

https://codereview.chromium.org/1667073002/diff/1/test/mjsunit/ignition/debug...
File test/mjsunit/ignition/debugger-statement.js (right):

https://codereview.chromium.org/1667073002/diff/1/test/mjsunit/ignition/debug...
test/mjsunit/ignition/debugger-statement.js:5: // Flags: --ignition
--ignition-filter=f --expose-debug-as debug
As discussed offline: This will unleash the full fury of ClsuertFuzz on
Ignition. Until we agreed on a way to proceed with how ClusterFuzz should deal
with Ignition, we should just temporarily remove these flags.

[rmcilroy, 2016-02-04 12:37:17]

Nice, lgtm, thanks!

https://codereview.chromium.org/1667073002/diff/1/src/compiler/interpreter-as...
File src/compiler/interpreter-assembler.h (right):

https://codereview.chromium.org/1667073002/diff/1/src/compiler/interpreter-as...
src/compiler/interpreter-assembler.h:139: Node* CallRuntime(Runtime::FunctionId
function_id);
I just added the same function in https://codereview.chromium.org/1665853002/,
so you should be able to remove this and the RMA changes.

https://codereview.chromium.org/1667073002/diff/1/test/cctest/interpreter/tes...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1667073002/diff/1/test/cctest/interpreter/tes...
test/cctest/interpreter/test-bytecode-generator.cc:7662: B(Debugger),      //
https://codereview.chromium.org/1665853002/ will add a B(StackCheck) at the
start of the function.

Also, could you add "// clang-format off" before and  "// clang-format on" after
the snippet, and format the snippet like the others.

[Yang, 2016-02-04 13:43:54]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-04 13:43:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1667073002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-02-04 13:43:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667073002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667073002/20001

[Yang, 2016-02-04 13:47:06]

https://codereview.chromium.org/1667073002/diff/1/src/compiler/interpreter-as...
File src/compiler/interpreter-assembler.h (right):

https://codereview.chromium.org/1667073002/diff/1/src/compiler/interpreter-as...
src/compiler/interpreter-assembler.h:139: Node* CallRuntime(Runtime::FunctionId
function_id);
On 2016/02/04 12:37:17, rmcilroy wrote:
> I just added the same function in https://codereview.chromium.org/1665853002/,
> so you should be able to remove this and the RMA changes.

Done.

https://codereview.chromium.org/1667073002/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):

https://codereview.chromium.org/1667073002/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:1807: // Debugger statement
On 2016/02/04 11:45:38, Michael Starzinger wrote:
> nit: Drop "statement".

Done.

https://codereview.chromium.org/1667073002/diff/1/test/cctest/interpreter/tes...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1667073002/diff/1/test/cctest/interpreter/tes...
test/cctest/interpreter/test-bytecode-generator.cc:7662: B(Debugger),      //
On 2016/02/04 12:37:17, rmcilroy wrote:
> https://codereview.chromium.org/1665853002/ will add a B(StackCheck) at the
> start of the function.
> 
> Also, could you add "// clang-format off" before and  "// clang-format on"
after
> the snippet, and format the snippet like the others.

Done.

https://codereview.chromium.org/1667073002/diff/1/test/mjsunit/ignition/debug...
File test/mjsunit/ignition/debugger-statement.js (right):

https://codereview.chromium.org/1667073002/diff/1/test/mjsunit/ignition/debug...
test/mjsunit/ignition/debugger-statement.js:5: // Flags: --ignition
--ignition-filter=f --expose-debug-as debug
On 2016/02/04 11:45:38, Michael Starzinger wrote:
> As discussed offline: This will unleash the full fury of ClsuertFuzz on
> Ignition. Until we agreed on a way to proceed with how ClusterFuzz should deal
> with Ignition, we should just temporarily remove these flags.

Done.

[commit-bot: I haz the power, 2016-02-04 13:58:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 13:58:27]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Yang, 2016-02-04 14:40:23]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-04 14:40:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1667073002/#ps40001
(title: "fix test expectation")

[commit-bot: I haz the power, 2016-02-04 14:40:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667073002/40001

[commit-bot: I haz the power, 2016-02-04 15:06:30]

Description was changed from

==========
[interpreter, debugger] implement debugger statement.

R=mstarzinger@chromium.org, rmcilroy@chromium.org
BUG=v8:4690
LOG=N
==========

to

==========
[interpreter, debugger] implement debugger statement.

R=mstarzinger@chromium.org, rmcilroy@chromium.org
BUG=v8:4690
LOG=N
==========

[commit-bot: I haz the power, 2016-02-04 15:06:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-04 15:07:14]

Description was changed from

==========
[interpreter, debugger] implement debugger statement.

R=mstarzinger@chromium.org, rmcilroy@chromium.org
BUG=v8:4690
LOG=N
==========

to

==========
[interpreter, debugger] implement debugger statement.

R=mstarzinger@chromium.org, rmcilroy@chromium.org
BUG=v8:4690
LOG=N

Committed: https://crrev.com/86164a2573a7c1bbf2d29f8d03de35fa7fff5c81
Cr-Commit-Position: refs/heads/master@{#33739}
==========

[commit-bot: I haz the power, 2016-02-04 15:07:15]

Patchset 3 (id:??) landed as
https://crrev.com/86164a2573a7c1bbf2d29f8d03de35fa7fff5c81
Cr-Commit-Position: refs/heads/master@{#33739}