Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 1667053002: Inline SVGImage::setContainerSize() and remove extra resize call (Closed)

Created:
4 years, 10 months ago by davve
Modified:
4 years, 10 months ago
Reviewers:
fs
CC:
chromium-reviews, krit, kouhei+svg_chromium.org, f(malita), blink-reviews, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline SVGImage::setContainerSize() and remove extra resize call DrawInternal() is responsible for resizing the frame to the new container size. Setting the frame size to the old container size temporarily ought to be a redundant operation. BUG=581357 Committed: https://crrev.com/15f0bca570b644f01b0d75e0967450993183c1d7 Cr-Commit-Position: refs/heads/master@{#373517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -17 lines) Patch
M third_party/WebKit/Source/core/svg/graphics/SVGImage.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 2 chunks +5 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667053002/1
4 years, 10 months ago (2016-02-04 08:48:47 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 10:08:13 UTC) #4
davve
This extra resize call has confused me from time to time. Let's see if we ...
4 years, 10 months ago (2016-02-04 10:29:50 UTC) #6
fs
On 2016/02/04 at 10:29:50, davve wrote: > This extra resize call has confused me from ...
4 years, 10 months ago (2016-02-04 11:17:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667053002/1
4 years, 10 months ago (2016-02-04 12:45:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 12:50:18 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 12:51:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15f0bca570b644f01b0d75e0967450993183c1d7
Cr-Commit-Position: refs/heads/master@{#373517}

Powered by Google App Engine
This is Rietveld 408576698