Use Future for error handling

pkg/analysis_server/lib/src/analysis_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis.server;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/analysis_logger.dart';
 import 'package:analysis_server/src/channel.dart';
@@ skipping 118 matching lines @@
       } else { //if (context.analysisOptions.provideErrors) {
         sendNotices(notices);
       }
     }
     //
     // Schedule this method to be run again if there is any more work to be done.
     //
     if (contextWorkQueue.isEmpty) {
       running = false;
     } else {
-      Timer.run(() {
-        performTask();
+      new Future(performTask).catchError((exception, stackTrace) {

[devoncarew, 2014/02/18 17:15:21]

Does performTask() throw? I think that's the only way that the catchError
handler will be called.

[Brian Wilkerson, 2014/02/18 17:18:38]

Not if it's working as expected, but an exception could be thrown if there's a
bug in the code somewhere. I'd rather that an exception didn't crash the server,
and this is my understanding of how to prevent that.

+        AnalysisEngine.instance.logger.logError3(exception);
       });
     }
   }
 
   /**
    * Send the information in the given list of notices back to the client.
    */
   void sendNotices(List<ChangeNotice> notices) {
     for (int i = 0; i < notices.length; i++) {
       ChangeNotice notice = notices[i];
@@ skipping 17 matching lines @@
     }
   }
 
   /**
    * Send the given [notification] to the client.
    */
   void sendNotification(Notification notification) {
     channel.sendNotification(notification);
   }
 }