Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 166703003: DevTools: Simplify mergeOrIntersect (Closed)

Created:
6 years, 10 months ago by alph
Modified:
6 years, 10 months ago
Reviewers:
caseq, vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Simplify mergeOrIntersect Drive by: 1. The original mergeOrIntersect had a bug causing e.g. []x[1,2,3] produce [1,2,3]. 2. findFilesMatchingSearchRequest had a bug that relied on #1 and produced almost correct results. Both are fixed with this patch. R=pfeldman@chromium.org, vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167282

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comment. #

Total comments: 3

Patch Set 3 : Added \n #

Patch Set 4 : Added a test. Fixed findFilesMatchingSearchRequest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -25 lines) Patch
M LayoutTests/inspector/utilities.html View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
M LayoutTests/inspector/utilities-expected.txt View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/FileSystemProjectDelegate.js View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/utilities.js View 1 2 1 chunk +14 lines, -23 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
alph
ptal
6 years, 10 months ago (2014-02-14 13:01:30 UTC) #1
pfeldman
https://codereview.chromium.org/166703003/diff/1/Source/devtools/front_end/utilities.js File Source/devtools/front_end/utilities.js (right): https://codereview.chromium.org/166703003/diff/1/Source/devtools/front_end/utilities.js#newcode730 Source/devtools/front_end/utilities.js:730: result = result.concat(array1.slice(i)); Isn't this expensive? Both concat and ...
6 years, 10 months ago (2014-02-14 16:02:17 UTC) #2
alph
https://codereview.chromium.org/166703003/diff/1/Source/devtools/front_end/utilities.js File Source/devtools/front_end/utilities.js (right): https://codereview.chromium.org/166703003/diff/1/Source/devtools/front_end/utilities.js#newcode730 Source/devtools/front_end/utilities.js:730: result = result.concat(array1.slice(i)); On 2014/02/14 16:02:17, pfeldman wrote: > ...
6 years, 10 months ago (2014-02-14 16:31:36 UTC) #3
caseq
https://codereview.chromium.org/166703003/diff/60001/Source/devtools/front_end/utilities.js File Source/devtools/front_end/utilities.js (right): https://codereview.chromium.org/166703003/diff/60001/Source/devtools/front_end/utilities.js#newcode730 Source/devtools/front_end/utilities.js:730: while (i < array1.length) result.push(array1[i++]); result.*$ => next line ...
6 years, 10 months ago (2014-02-14 16:49:03 UTC) #4
alph
https://codereview.chromium.org/166703003/diff/60001/Source/devtools/front_end/utilities.js File Source/devtools/front_end/utilities.js (right): https://codereview.chromium.org/166703003/diff/60001/Source/devtools/front_end/utilities.js#newcode730 Source/devtools/front_end/utilities.js:730: while (i < array1.length) result.push(array1[i++]); On 2014/02/14 16:49:03, caseq ...
6 years, 10 months ago (2014-02-14 16:51:20 UTC) #5
pfeldman
lgtm. thanks!
6 years, 10 months ago (2014-02-14 17:17:41 UTC) #6
alph
The CQ bit was checked by alph@chromium.org
6 years, 10 months ago (2014-02-14 17:20:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/166703003/110001
6 years, 10 months ago (2014-02-14 17:54:11 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 19:35:19 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=21890
6 years, 10 months ago (2014-02-14 19:35:20 UTC) #10
alph
The CQ bit was checked by alph@chromium.org
6 years, 10 months ago (2014-02-14 21:55:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/166703003/110001
6 years, 10 months ago (2014-02-14 21:56:11 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 23:23:11 UTC) #13
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=18784
6 years, 10 months ago (2014-02-14 23:23:12 UTC) #14
alph
Pavel, Vsevik, could you please take one more look at the patch as surprisingly it ...
6 years, 10 months ago (2014-02-17 10:28:35 UTC) #15
vsevik
lgtm
6 years, 10 months ago (2014-02-17 12:33:30 UTC) #16
alph
The CQ bit was checked by alph@chromium.org
6 years, 10 months ago (2014-02-17 12:35:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/166703003/400001
6 years, 10 months ago (2014-02-17 12:35:42 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-17 15:50:55 UTC) #19
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=12775
6 years, 10 months ago (2014-02-17 15:50:55 UTC) #20
alph
The CQ bit was checked by alph@chromium.org
6 years, 10 months ago (2014-02-17 16:01:43 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/166703003/400001
6 years, 10 months ago (2014-02-17 16:02:05 UTC) #22
alph
6 years, 10 months ago (2014-02-17 16:05:59 UTC) #23
Message was sent while issue was closed. 
Committed patchset #4 manually as r167282 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698