Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: net/quic/quic_unacked_packet_map_test.cc

Issue 1667003002: Replace QuicEncryptedPacket's fields with equivalents in SerializedPacket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@113395732
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_sent_packet_manager_test.cc ('k') | net/quic/quic_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_unacked_packet_map_test.cc
diff --git a/net/quic/quic_unacked_packet_map_test.cc b/net/quic/quic_unacked_packet_map_test.cc
index 287658f98d18c790b9bcfccaf1d9610788f9a3cb..a422db1541f427617660084578eee7eaa4ffb21c 100644
--- a/net/quic/quic_unacked_packet_map_test.cc
+++ b/net/quic/quic_unacked_packet_map_test.cc
@@ -37,10 +37,9 @@ class QuicUnackedPacketMapTest : public ::testing::Test {
SerializedPacket CreateRetransmittablePacketForStream(
QuicPacketNumber packet_number,
QuicStreamId stream_id) {
- packets_.push_back(new QuicEncryptedPacket(nullptr, kDefaultLength));
SerializedPacket packet(kDefaultPathId, packet_number,
- PACKET_1BYTE_PACKET_NUMBER, packets_.back(), 0,
- false, false);
+ PACKET_1BYTE_PACKET_NUMBER, nullptr, kDefaultLength,
+ 0, false, false);
QuicStreamFrame* frame = new QuicStreamFrame();
frame->stream_id = stream_id;
packet.retransmittable_frames.push_back(QuicFrame(frame));
@@ -49,10 +48,9 @@ class QuicUnackedPacketMapTest : public ::testing::Test {
SerializedPacket CreateNonRetransmittablePacket(
QuicPacketNumber packet_number) {
- packets_.push_back(new QuicEncryptedPacket(nullptr, kDefaultLength));
return SerializedPacket(kDefaultPathId, packet_number,
- PACKET_1BYTE_PACKET_NUMBER, packets_.back(), 0,
- false, false);
+ PACKET_1BYTE_PACKET_NUMBER, nullptr, kDefaultLength,
+ 0, false, false);
}
void VerifyInFlightPackets(QuicPacketNumber* packets, size_t num_packets) {
« no previous file with comments | « net/quic/quic_sent_packet_manager_test.cc ('k') | net/quic/quic_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698