Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1854)

Unified Diff: net/quic/quic_connection.h

Issue 1667003002: Replace QuicEncryptedPacket's fields with equivalents in SerializedPacket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@113395732
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/congestion_control/general_loss_algorithm_test.cc ('k') | net/quic/quic_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.h
diff --git a/net/quic/quic_connection.h b/net/quic/quic_connection.h
index b3fcdf6b7c61d33c6fa859f50cad63155910aba6..9935e27d51c25fe8e11347dc38e54b0d2361d9c6 100644
--- a/net/quic/quic_connection.h
+++ b/net/quic/quic_connection.h
@@ -712,10 +712,6 @@ class NET_EXPORT_PRIVATE QuicConnection
// writer is write blocked.
bool WritePacket(SerializedPacket* packet);
- // Does the main work of WritePacket, but does not delete the packet or
- // retransmittable frames upon success.
- bool WritePacketInner(SerializedPacket* packet);
-
// Make sure an ack we got from our peer is sane.
// Returns nullptr for valid acks or an error std::string if it was invalid.
const char* ValidateAckFrame(const QuicAckFrame& incoming_ack);
@@ -882,8 +878,10 @@ class NET_EXPORT_PRIVATE QuicConnection
bool pending_version_negotiation_packet_;
// When packets could not be sent because the socket was not writable,
- // they are added to this list. All corresponding frames are in
- // unacked_packets_ if they are to be retransmitted.
+ // they are added to this std::list. All corresponding frames are in
+ // unacked_packets_ if they are to be retransmitted. Packets encrypted_buffer
+ // fields are owned by the QueuedPacketList, in order to ensure they outlast
+ // the original scope of the SerializedPacket.
QueuedPacketList queued_packets_;
// If true, then crypto packets will be saved as termination packets.
« no previous file with comments | « net/quic/congestion_control/general_loss_algorithm_test.cc ('k') | net/quic/quic_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698