test_runner.py Fix error message being intertwined with log messages

test_runner.py Fix error message being intertwined with log messages

Before change:

I    0.025s Main  Using device cache: /usr/local/...
Could not find apk or executable for base_unittestsI    0.026s Main Wrote device cache: /usr/...
E    0.028s Main  Unrecognized error occurred.

After change:

I    0.025s Main  Using device cache: /usr/local/...
C    0.025s Main  Could not find apk or executable for base_unittests
I    0.026s Main  Wrote device cache: /usr/local/...

BUG=None

Committed: https://crrev.com/63d20783065cf2866ff4c525f3679ebd35c5500d
Cr-Commit-Position: refs/heads/master@{#373559}

[agrieve, 2016-02-04 03:08:15]

Description was changed from

==========
test_runner.py Fix error message being intertwined with log messages

Before change:

I    0.025s Main  Using device cache: /usr/local/...
Could not find apk or executable for base_unittestsI    0.026s Main Wrote device
cache: /usr/...
E    0.028s Main  Unrecognized error occurred.

After change:

I    0.025s Main  Using device cache: /usr/local/...
C    0.025s Main  Could not find apk or executable for base_unittests
I    0.026s Main  Wrote device cache: /usr/local/...

BUG=None
==========

to

==========
test_runner.py Fix error message being intertwined with log messages

Before change:

I    0.025s Main  Using device cache: /usr/local/...
Could not find apk or executable for base_unittestsI    0.026s Main Wrote device
cache: /usr/...
E    0.028s Main  Unrecognized error occurred.

After change:

I    0.025s Main  Using device cache: /usr/local/...
C    0.025s Main  Could not find apk or executable for base_unittests
I    0.026s Main  Wrote device cache: /usr/local/...

BUG=None
==========

[agrieve, 2016-02-04 03:08:15]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2016-02-04 03:08:25]

On 2016/02/04 03:08:15, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:jbudorick@chromium.org

☼

[jbudorick, 2016-02-04 05:37:53]

Hm. My concern with this is that a lot of the argument handling happens down in
the environment and test_instance subclasses.

That said, I'd rather have a bad argument logged fatally outside the
ArgumentParser mechanism than have some other failure logged inside it, so lgtm.

[agrieve, 2016-02-04 16:07:53]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-02-04 16:08:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1666983002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1666983002/1

[commit-bot: I haz the power, 2016-02-04 17:47:32]

Description was changed from

==========
test_runner.py Fix error message being intertwined with log messages

Before change:

I    0.025s Main  Using device cache: /usr/local/...
Could not find apk or executable for base_unittestsI    0.026s Main Wrote device
cache: /usr/...
E    0.028s Main  Unrecognized error occurred.

After change:

I    0.025s Main  Using device cache: /usr/local/...
C    0.025s Main  Could not find apk or executable for base_unittests
I    0.026s Main  Wrote device cache: /usr/local/...

BUG=None
==========

to

==========
test_runner.py Fix error message being intertwined with log messages

Before change:

I    0.025s Main  Using device cache: /usr/local/...
Could not find apk or executable for base_unittestsI    0.026s Main Wrote device
cache: /usr/...
E    0.028s Main  Unrecognized error occurred.

After change:

I    0.025s Main  Using device cache: /usr/local/...
C    0.025s Main  Could not find apk or executable for base_unittests
I    0.026s Main  Wrote device cache: /usr/local/...

BUG=None
==========

[commit-bot: I haz the power, 2016-02-04 17:47:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-04 17:48:48]

Description was changed from

==========
test_runner.py Fix error message being intertwined with log messages

Before change:

I    0.025s Main  Using device cache: /usr/local/...
Could not find apk or executable for base_unittestsI    0.026s Main Wrote device
cache: /usr/...
E    0.028s Main  Unrecognized error occurred.

After change:

I    0.025s Main  Using device cache: /usr/local/...
C    0.025s Main  Could not find apk or executable for base_unittests
I    0.026s Main  Wrote device cache: /usr/local/...

BUG=None
==========

to

==========
test_runner.py Fix error message being intertwined with log messages

Before change:

I    0.025s Main  Using device cache: /usr/local/...
Could not find apk or executable for base_unittestsI    0.026s Main Wrote device
cache: /usr/...
E    0.028s Main  Unrecognized error occurred.

After change:

I    0.025s Main  Using device cache: /usr/local/...
C    0.025s Main  Could not find apk or executable for base_unittests
I    0.026s Main  Wrote device cache: /usr/local/...

BUG=None

Committed: https://crrev.com/63d20783065cf2866ff4c525f3679ebd35c5500d
Cr-Commit-Position: refs/heads/master@{#373559}
==========

[commit-bot: I haz the power, 2016-02-04 17:48:49]

Patchset 1 (id:??) landed as
https://crrev.com/63d20783065cf2866ff4c525f3679ebd35c5500d
Cr-Commit-Position: refs/heads/master@{#373559}