Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1666833002: Add missing arm64 simd build rules for libjpeg_turbo for GN (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing arm64 simd build rules for libjpeg_turbo for GN They already existed for GYP build. Should fix the perf regression in associated bug. BUG=580983 Committed: https://crrev.com/d57925460a7edc126994392be7c7e159f4222d70 Cr-Commit-Position: refs/heads/master@{#373411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/secondary/third_party/libjpeg_turbo/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
agrieve
On 2016/02/03 21:37:15, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:pkotwicz@chromium.org ヽ(•‿•)ノ
4 years, 10 months ago (2016-02-03 21:37:30 UTC) #3
pkotwicz
LGTM
4 years, 10 months ago (2016-02-03 21:45:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666833002/1
4 years, 10 months ago (2016-02-04 00:44:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 01:21:18 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 01:22:38 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d57925460a7edc126994392be7c7e159f4222d70
Cr-Commit-Position: refs/heads/master@{#373411}

Powered by Google App Engine
This is Rietveld 408576698