Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1666813002: Fix assert accessing pipeline from initBatchTracker (Closed)

Created:
4 years, 10 months ago by Chris Dalton
Modified:
4 years, 10 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix assert accessing pipeline from initBatchTracker Marks fPipelineInstalled as true before calling initBatchTracker. The batch subclass ought to be able to access the newly constructed pipeline object during its init. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1666813002 Committed: https://skia.googlesource.com/skia/+/e62cbdffcf27278272e87de65a07dddc24605ad7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/batches/GrDrawBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Chris Dalton
4 years, 10 months ago (2016-02-03 20:59:15 UTC) #3
joshualitt
On 2016/02/03 20:59:15, Chris Dalton wrote: lgtm
4 years, 10 months ago (2016-02-03 20:59:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666813002/1
4 years, 10 months ago (2016-02-03 21:01:24 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 21:29:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e62cbdffcf27278272e87de65a07dddc24605ad7

Powered by Google App Engine
This is Rietveld 408576698