Add GL indirect drawing APIs

Add GL indirect drawing APIs

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1666803002

Committed: https://skia.googlesource.com/skia/+/06604b95622359640a1c2028b885646deda28d52

[Chris Dalton, 2016-02-03 20:51:39]

Description was changed from

==========
Add GL indirect drawing APIs

BUG=skia:
==========

to

==========
Add GL indirect drawing APIs

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Chris Dalton, 2016-02-03 20:52:12]

cdalton@nvidia.com changed reviewers:
+ bsalomon@google.com

[Chris Dalton, 2016-02-03 20:52:13]

This one is really simple

[bsalomon, 2016-02-04 16:33:41]

lgtm, minor suggestions inline

https://codereview.chromium.org/1666803002/diff/1/include/gpu/gl/GrGLTypes.h
File include/gpu/gl/GrGLTypes.h (right):

https://codereview.chromium.org/1666803002/diff/1/include/gpu/gl/GrGLTypes.h#...
include/gpu/gl/GrGLTypes.h:62: typedef struct {
Do we really need typedef struct? I don't really care but we'll never compile
this with a C compiler.

https://codereview.chromium.org/1666803002/diff/1/src/gpu/gl/GrGLCaps.h
File src/gpu/gl/GrGLCaps.h (right):

https://codereview.chromium.org/1666803002/diff/1/src/gpu/gl/GrGLCaps.h#newco...
src/gpu/gl/GrGLCaps.h:288: bool drawIndirectSupport() const {
maybe make these one line just to match the similar functions above?

[Chris Dalton, 2016-02-04 20:45:55]

Just one quick question in the comments.

https://codereview.chromium.org/1666803002/diff/1/include/gpu/gl/GrGLTypes.h
File include/gpu/gl/GrGLTypes.h (right):

https://codereview.chromium.org/1666803002/diff/1/include/gpu/gl/GrGLTypes.h#...
include/gpu/gl/GrGLTypes.h:62: typedef struct {
On 2016/02/04 16:33:41, bsalomon wrote:
> Do we really need typedef struct? I don't really care but we'll never compile
> this with a C compiler.

No, I just wrote them as typedefs to feel more like they were copy-pasted from
gl.h.

Also I named the fields with the same names that they have in gl.h. Would it be
better to start them with an f inside of skia?

  GrGLuint fCount;
  GrGLuint fInstanceCount;
  ...

https://codereview.chromium.org/1666803002/diff/1/src/gpu/gl/GrGLCaps.h
File src/gpu/gl/GrGLCaps.h (right):

https://codereview.chromium.org/1666803002/diff/1/src/gpu/gl/GrGLCaps.h#newco...
src/gpu/gl/GrGLCaps.h:288: bool drawIndirectSupport() const {
On 2016/02/04 16:33:41, bsalomon wrote:
> maybe make these one line just to match the similar functions above?

Oops, don't know how I missed that :-\

[bsalomon, 2016-02-04 21:01:15]

https://codereview.chromium.org/1666803002/diff/1/include/gpu/gl/GrGLTypes.h
File include/gpu/gl/GrGLTypes.h (right):

https://codereview.chromium.org/1666803002/diff/1/include/gpu/gl/GrGLTypes.h#...
include/gpu/gl/GrGLTypes.h:62: typedef struct {
On 2016/02/04 20:45:55, Chris Dalton wrote:
> On 2016/02/04 16:33:41, bsalomon wrote:
> > Do we really need typedef struct? I don't really care but we'll never
compile
> > this with a C compiler.
> 
> No, I just wrote them as typedefs to feel more like they were copy-pasted from
> gl.h.
> 
> Also I named the fields with the same names that they have in gl.h. Would it
be
> better to start them with an f inside of skia?
> 
>   GrGLuint fCount;
>   GrGLuint fInstanceCount;
>   ...

That's a good point, we should either go all in on Gr or GL style. I'd prefer
sticking with Gr style (fField) just to avoid having a different set of rules to
follow here.

[Chris Dalton, 2016-02-04 21:05:41]

Updated the variable naming style.

Was there anything else or is this ready to go now?

https://codereview.chromium.org/1666803002/diff/1/include/gpu/gl/GrGLTypes.h
File include/gpu/gl/GrGLTypes.h (right):

https://codereview.chromium.org/1666803002/diff/1/include/gpu/gl/GrGLTypes.h#...
include/gpu/gl/GrGLTypes.h:62: typedef struct {
On 2016/02/04 21:01:15, bsalomon wrote:
> On 2016/02/04 20:45:55, Chris Dalton wrote:
> > On 2016/02/04 16:33:41, bsalomon wrote:
> > > Do we really need typedef struct? I don't really care but we'll never
> compile
> > > this with a C compiler.
> > 
> > No, I just wrote them as typedefs to feel more like they were copy-pasted
from
> > gl.h.
> > 
> > Also I named the fields with the same names that they have in gl.h. Would it
> be
> > better to start them with an f inside of skia?
> > 
> >   GrGLuint fCount;
> >   GrGLuint fInstanceCount;
> >   ...
> 
> That's a good point, we should either go all in on Gr or GL style. I'd prefer
> sticking with Gr style (fField) just to avoid having a different set of rules
to
> follow here.

Sounds good.

[bsalomon, 2016-02-04 21:06:23]

On 2016/02/04 21:05:41, Chris Dalton wrote:
> Updated the variable naming style.
> 
> Was there anything else or is this ready to go now?
> 
> https://codereview.chromium.org/1666803002/diff/1/include/gpu/gl/GrGLTypes.h
> File include/gpu/gl/GrGLTypes.h (right):
> 
>
https://codereview.chromium.org/1666803002/diff/1/include/gpu/gl/GrGLTypes.h#...
> include/gpu/gl/GrGLTypes.h:62: typedef struct {
> On 2016/02/04 21:01:15, bsalomon wrote:
> > On 2016/02/04 20:45:55, Chris Dalton wrote:
> > > On 2016/02/04 16:33:41, bsalomon wrote:
> > > > Do we really need typedef struct? I don't really care but we'll never
> > compile
> > > > this with a C compiler.
> > > 
> > > No, I just wrote them as typedefs to feel more like they were copy-pasted
> from
> > > gl.h.
> > > 
> > > Also I named the fields with the same names that they have in gl.h. Would
it
> > be
> > > better to start them with an f inside of skia?
> > > 
> > >   GrGLuint fCount;
> > >   GrGLuint fInstanceCount;
> > >   ...
> > 
> > That's a good point, we should either go all in on Gr or GL style. I'd
prefer
> > sticking with Gr style (fField) just to avoid having a different set of
rules
> to
> > follow here.
> 
> Sounds good.

lgtm

[Chris Dalton, 2016-02-04 21:06:48]

The CQ bit was checked by cdalton@nvidia.com

[commit-bot: I haz the power, 2016-02-04 21:06:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 21:06:53]

This CL has an open dependency (Issue 1666563003 Patch 40001). Please resolve
the dependency and try again.

[Chris Dalton, 2016-02-05 17:44:55]

The CQ bit was checked by cdalton@nvidia.com

[commit-bot: I haz the power, 2016-02-05 17:45:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1666803002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1666803002/40001

[commit-bot: I haz the power, 2016-02-05 18:09:53]

Description was changed from

==========
Add GL indirect drawing APIs

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add GL indirect drawing APIs

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/06604b95622359640a1c2028b885646deda28d52
==========

[commit-bot: I haz the power, 2016-02-05 18:09:53]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/06604b95622359640a1c2028b885646deda28d52